Fix comment, bad and pointless exception handling

Fix copyright year.
Fix doc for new commands.
Fix bad exception handling.
Remove pointless warning message.

Author: matthewrmshin

bin/cylc-checkpoint

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 
 # THIS FILE IS PART OF THE CYLC SUITE ENGINE.
-# Copyright (C) 2008-2016 NIWA
+# Copyright (C) 2008-2018 NIWA
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by

bin/cylc-client

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 
 # THIS FILE IS PART OF THE CYLC SUITE ENGINE.
-# Copyright (C) 2008-2016 NIWA
+# Copyright (C) 2008-2018 NIWA
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -31,7 +31,6 @@ if '--use-ssh' in sys.argv[1:]:
     if remrun():
         sys.exit(0)
 
-import cylc.flags
 from cylc.option_parsers import CylcOptionParser as COP
 from cylc.network.httpclient import SuiteRuntimeServiceClient
 

bin/cylc-message

@@ -28,9 +28,9 @@ Task jobs use this command to record and report status such as success and
 failure. Applications run by task jobs can use this command to report messages
 and to report registered task outputs.
 
-Messages can be specified as arguments. A '-' indicates that messages the
-command should read messages from STDIN. When reading from STDIN, multiple
-messages are separated by empty lines.
+Messages can be specified as arguments. A '-' indicates that the command should
+read messages from STDIN. When reading from STDIN, multiple messages are
+separated by empty lines.
 
 Each message can be prefixed with a severity level using the syntax 'SEVERITY:
 MESSAGE'.

bin/cylc-spawn

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 
 # THIS FILE IS PART OF THE CYLC SUITE ENGINE.
-# Copyright (C) 2008-2015 NIWA
+# Copyright (C) 2008-2018 NIWA
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by

lib/cylc/network/httpclient.py

@@ -285,21 +285,15 @@ def put_messages(self, payload):
                             func_name, task_id='%s.%s' % (name, cycle),
                             priority=severity, message=message))
             except ClientInfoError:
+                # Contact info file not found, suite probably not running.
+                # Don't bother with retry, suite restart will poll any way.
                 raise
             except ClientError as exc:
                 now = get_current_time_string()
                 sys.stderr.write(
                     "%s WARNING - Message send failed, try %s of %s: %s\n" % (
                         now, i, max_tries, exc))
-                # Break if:
-                # * Exhausted number of tries.
-                # * Contact info file not found, suite probably not running.
-                #   Don't bother with retry, suite restart will poll any way.
-                if i >= max_tries or isinstance(exc, ClientInfoError):
-                    # Issue a warning and let the task carry on
-                    sys.stderr.write(
-                        "%s WARNING - MESSAGE SEND FAILED\n" % (now))
-                else:
+                if i < max_tries:
                     sys.stderr.write(
                         "   retry in %s seconds, timeout is %s\n" % (
                             retry_intvl, self.timeout))

tests/cylc-insert/10-insert-non-graphed-cycle-point.t

@@ -1,6 +1,6 @@
 #!/bin/bash
 # THIS FILE IS PART OF THE CYLC SUITE ENGINE.
-# Copyright (C) 2008-2016 NIWA
+# Copyright (C) 2008-2018 NIWA
 # 
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by

tests/task-proc-loop/00-count.t

@@ -1,6 +1,6 @@
 #!/bin/bash
 # THIS FILE IS PART OF THE CYLC SUITE ENGINE.
-# Copyright (C) 2008-2015 NIWA
+# Copyright (C) 2008-2018 NIWA
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by