Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lints workflow : msrv sometimes needs a crate directory #8

Open
huitseeker opened this issue Jan 1, 2024 · 1 comment
Open

lints workflow : msrv sometimes needs a crate directory #8

huitseeker opened this issue Jan 1, 2024 · 1 comment

Comments

@huitseeker
Copy link
Contributor

Because those repos contain multiple crates we want to check the msrv for, they need a custom msrv job that cds into the crate's root directory:

This makes the msrv step in the linting job from this repository unusable.

See lurk-lab/bellpepper-gadgets#13
See also #7, more specifically the suggestion of a crate parameter.

@samuelburnham
Copy link
Member

foresterre/cargo-msrv#882 added workspace support, which is released in cargo-msrv 0.16.0-beta.20, but when I tested cargo msrv verify it returned an empty output.

I still think it's worth waiting a few weeks/months for workspace support to land on a stable release, and use custom MSRV workflows for workspaces like https://github.com/lurk-lab/bellpepper-gadgets/blob/main/.github/workflows/rust.yml#L77 until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants