From 53b264054e47307d8351056f29c8808215e785a2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kamil=20=C5=9Aliwak?= Date: Wed, 6 Mar 2024 12:15:58 +0100 Subject: [PATCH 1/2] CI: Bump resource class to xlarge for uniswap and perpetual pools external tests --- .circleci/config.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 30c0229642a0..eb55dd3d2b90 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -783,6 +783,8 @@ defaults: project: perpetual-pools binary_type: native image: cimg/node:18.16 + # FIXME: This used to work with small, but now runs out of memory on anything below xlarge. + resource_class: xlarge - job_native_test_ext_uniswap: &job_native_test_ext_uniswap <<: *requires_b_ubu_static @@ -790,6 +792,8 @@ defaults: project: uniswap binary_type: native image: cimg/node:18.16 + # FIXME: This used to work with small, but now runs out of memory on anything below xlarge. + resource_class: xlarge - job_native_test_ext_prb_math: &job_native_test_ext_prb_math <<: *requires_b_ubu_static From 139ba516259ccdd08906c9b0ebb4b5870ed4a452 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kamil=20=C5=9Aliwak?= Date: Wed, 6 Mar 2024 15:44:12 +0100 Subject: [PATCH 2/2] perpetual-pools: Disable a test failing due to dict key order non-determinism --- test/externalTests/perpetual-pools.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/externalTests/perpetual-pools.sh b/test/externalTests/perpetual-pools.sh index 31748a40ca2a..67e8fa57e629 100755 --- a/test/externalTests/perpetual-pools.sh +++ b/test/externalTests/perpetual-pools.sh @@ -64,6 +64,10 @@ function perpetual_pools_test sed -i 's|\(it\)\(("Should not allow commits that are too large"\)|\1.skip\2|g' test/PoolCommitter/commit.spec.ts sed -i 's|\(it\)\(("Should not allow for too many commitments (that bring amount over a user'\''s balance)"\)|\1.skip\2|g' test/PoolCommitter/commit.spec.ts + # Disable a test failing due to a non-deterministic order of keys in a returned dict. + # TODO: Figure out why it's failing and re-enable. + sed -i 's|\(it\)\(("Rotates the observations array"\)|\1.skip\2|g' test/PriceObserver.spec.ts + neutralize_package_lock neutralize_package_json_hooks force_hardhat_compiler_binary "$config_file" "$BINARY_TYPE" "$BINARY_PATH"