-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't configure Executor args
. Is it intended?
#12315
Comments
@zamonia500 Executor Container customization is only supporting a few elements. We need to improve the Docs. argo-workflows/workflow/controller/workflowpod.go Lines 600 to 606 in 544ed90
Can you provide your usecase to use |
I have deployed minio tenant into kubernetes deployed argo-workflow-controller too. I have to communicate with minio with https protocol. But https certificate created by minio operator is self-signed! |
you can configure this on your workflow.
|
Found the same issue trying to set the loglevel. Didn't matter what the Config map data:
executor: |
args:
- --loglevel
- debug
- --gloglevel
- "6"
Init Containers:
init:
# ...
Command:
argoexec
init
--loglevel
info
--log-format
text I can see from the workflow controller logs that it picked up the supplied config map settings
The log levels are specifically called out in the documentation so it's very disappointing the |
@sarabala1979 , |
@philBrown , AFAIK loglevel configuration is following the |
You should be able to set this in your |
I double-checked, and it looks like @sarabala1979 do you have any thoughts on adding this back? I'm inclined to do so since it seems to have been accidentally removed and therefore was a regression, rather than an explicit feature removal. As a workaround, I believe you could use |
@agilgur5 , Oh! i missed that configmap field :( I already have resolved this issue by customize exec container. So it doesn't matter to me this issue gonna clone right now or not, but seems the root cause of |
this is correct
Wrote up a PR and added a regression test for this there: #12609 |
args
. Is it intended?
Pre-requisites
:latest
What happened/what did you expect to happen?
I'd like to customize the args of executor containers to append extra argument for turn on some flags on
argoexec
image.When i have referred to documents workflow-controller-configmap.yaml , it seems that customization of executor container was supported up until some point.
argo-workflows/docs/workflow-controller-configmap.yaml
Lines 234 to 254 in 544ed90
I tried to customize args of executor containers via update
workflow-controller-configmap
following to latest schema. But it didn't work. My customize configuration is ignored by workflow controller.So, i have inspected the reason of the ignorance and figured out there is no handling code to apply the customize configuration into executors(init, wait containers).
argo-workflows/workflow/controller/workflowpod.go
Lines 513 to 523 in 544ed90
Version
v3.5.1
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
After i create the hello-world workflow the workflow pod is customized as follows.
You can find the environment variable is injected well.
Logs from in your workflow's wait container
The text was updated successfully, but these errors were encountered: