Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make controller-image fails with No rule to make target 'controller' #1155

Closed
remster opened this issue Jan 4, 2019 · 1 comment · Fixed by #1189
Closed

make controller-image fails with No rule to make target 'controller' #1155

remster opened this issue Jan 4, 2019 · 1 comment · Fixed by #1189
Assignees
Labels
type/feature Feature request
Milestone

Comments

@remster
Copy link

remster commented Jan 4, 2019

Is this a BUG REPORT or FEATURE REQUEST?:
BUG REPORT
What happened:
When building image on minikube as docker repo (i.e.: eval $(minikube docker-env)) and as instructed here.

[remek][~/.../github.com/argoproj/argo][master]$ make controller-image executor-image IMAGE_TAG=latest IMAGE_NAMESPACE=jessesuen DOCKER_PUSH=true
docker build -t argo-builder -f Dockerfile-builder .
Sending build context to Docker daemon  39.42kB
...
Successfully built f73583d2d77b
Successfully tagged argo-builder:latest
docker run --rm -v /home/remek/go/src/github.com/argoproj/argo:/root/go/src/github.com/argoproj/argo -v /home/remek/go/src/github.com/argoproj/argo/dist/pkg:/root/go/pkg -w /root/go/src/github.com/argoproj/argo argo-builder make controller
make: *** No rule to make target 'controller'.  Stop.
Makefile:128: recipe for target 'controller-linux' failed
make: *** [controller-linux] Error 2

full log attached
argo_image_build.txt

What you expected to happen:
Build to succeed
How to reproduce it (as minimally and precisely as possible):
make controller-image executor-image IMAGE_TAG=latest IMAGE_NAMESPACE=jessesuen DOCKER_PUSH=true
Anything else we need to know?:

Environment:

  • Argo version:
building master on sha 3561bff70ad6bfeca8967be6aa4ac24fbbc8ac27
  • Kubernetes version :
N/A
  • minikube version:
minikube version: v0.32.0
@remster remster changed the title make controller-image fails with make controller-image executor-image IMAGE_TAG=latest make controller-image fails with No rule to make target 'controller' Jan 4, 2019
@jessesuen
Copy link
Member

jessesuen commented Jan 22, 2019

When using eval $(minikube docker-env), it uses the minikube docker daemon as the remote docker host, which does not have access to the local files, which we currently mount during the build phase. We will be rewriting the makefile to not use Docker volume binding (the -v option).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
2 participants