[argo-workflows] workflow-controller-cluster-role is missing delete configmap permission #2685
Labels
argo-workflows
awaiting-upstream
Is waiting for a change upstream to be completed before it can be merged.
bug
no-issue-activity
Describe the bug
about the issue
argo-workflows has a feature of
CACHE_GC_PERIOD
which helps in clean up of expired cache keys from ConfigMap and clean up of the ConfigMap which is having no data.https://github.com/argoproj/argo-workflows/blob/main/docs/environment-variables.md
In our setup we have enabled
CACHE_GC_PERIOD
and we get exceptions like below from workflows-controller when it tries to do the necessary cleanupsolution
I think the solution is a one-line change in charts/argo-workflows/templates/controller/workflow-controller-cluster-roles.yaml
adding
delete
permission should solve the issue. I have tried setting it manually in the ClusterRole on our cluster and it works fine.{{- if .Values.controller.rbac.writeConfigMaps }} - create - update + - delete {{- end}}
I am looking for suggestion/recommendation on the proposed solution.
If the solution looks alright, then I can go ahead and create a PR to make this change.
Related helm chart
argo-workflows
Helm chart version
0.41.2
To Reproduce
set cache GC configs from
values.yaml
and generated manifest and deploy argo-workflows to K8s.
Expected behavior
workflow-controller should have sufficient permissions to delete the configmaps which have no data if
CACHE_GC_PERIOD
is enabled.Screenshots
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: