Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Parallelize EnsureCleanState for e2e tests, adding timing information #20998

Merged
merged 24 commits into from
Dec 2, 2024
Merged

chore: Parallelize EnsureCleanState for e2e tests, adding timing information #20998

merged 24 commits into from
Dec 2, 2024

Commits on Nov 29, 2024

  1. chore: Parallelize EnsureCleanState for e2e tests, adding timing info… 

    …rmation

Closes argoproj#20968
Closes argoproj#20967

A number of cleanup and create steps can be done in parallel, reducing the total runtime. Gather timing information as well and log it.

Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    47eb7af View commit details
    Browse the repository at this point in the history

  2. Add underscores to function map keys 

    Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    3d35d72 View commit details
    Browse the repository at this point in the history

  3. Have separate log statements for timing fields, since everything does… 

    …n't fit in Github logs and gets truncated

Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    a869025 View commit details
    Browse the repository at this point in the history

  4. Re-run tests 

    Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    05867e7 View commit details
    Browse the repository at this point in the history

  5. Fix duplicate removal attempts, cleanup things in namespaces before r… 

    …emoving namespaces

Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    698534a View commit details
    Browse the repository at this point in the history

  6. Combine config map cleanups, since they seem to have some kind of loc… 

    …king based on timings

Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    e193943 View commit details
    Browse the repository at this point in the history

  7. Re-order some cleanups to not wait if something is already covered by… 

    … no wait commands

Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    58ea3fb View commit details
    Browse the repository at this point in the history

  8. Move rm temp dir to be together with re-creation, since otherwise rep… 

    …o server watcher seems to fail

Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    2aed64f View commit details
    Browse the repository at this point in the history

  9. Only update config maps and login as admin if there were any changes 

    Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    cee26fa View commit details
    Browse the repository at this point in the history

  10. Also check for user being logged in 

    Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    d34d634 View commit details
    Browse the repository at this point in the history

  11. Improve config maps equivalency check 

    Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    4760330 View commit details
    Browse the repository at this point in the history

  12. Remove timing information 

    Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    e58f2eb View commit details
    Browse the repository at this point in the history

  13. Improve loops with sleep 

    Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    af6e5f6 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2024

  1. Properly propagate and handle errors for parallel functions 

    Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Dec 1, 2024
    Configuration menu
    Copy the full SHA
    75a6395 View commit details
    Browse the repository at this point in the history

  2. Add missing CheckError 

    Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Dec 1, 2024
    Configuration menu
    Copy the full SHA
    94080a1 View commit details
    Browse the repository at this point in the history

  3. Fix import 

    Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Dec 1, 2024
    Configuration menu
    Copy the full SHA
    75b6bcf View commit details
    Browse the repository at this point in the history

  4. Fix imports linter error (try 2) 

    Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Dec 1, 2024
    Configuration menu
    Copy the full SHA
    0b58c3f View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. Parallelize EnsureCleanState for application sets 

    Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    297c9fa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into 20968-parallelize-ensure-clean-state-for-e… 

    …2e-tests

Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    c192ffe View commit details
    Browse the repository at this point in the history

  3. Fix errors.IsNotFound 

    Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    9be3af0 View commit details
    Browse the repository at this point in the history

  4. Use errgroup to run functions in parallel 

    Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    5126885 View commit details
    Browse the repository at this point in the history

  5. Remove name keys for functions as unused 

    Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    c1af11e View commit details
    Browse the repository at this point in the history

  6. Use apierr directly 

    Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    f0f6300 View commit details
    Browse the repository at this point in the history

  7. Re-run tests due to flake 

    Signed-off-by: Andrii Korotkov <[email protected]>
    @andrii-korotkov-verkada
    andrii-korotkov-verkada committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    e2f7cdd View commit details
    Browse the repository at this point in the history