feat: Add configurable Helm version (#3872)

[loxley]

This commit adds support for configurable Helm version either via
declarative syntax or via argocd cli.

New helm option 'Version' added to the ApplicationSourceHelm
struct which can be either 'v2' or 'v3'.

Argocd app create accepts '--helm-version' that also looks for the
same Helm versions as above.

Closes #3872 .

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Optional. My organization is added to USERS.md.
• I've signed the CLA and my build is green (troubleshooting builds).

[jannfis]

Hey, this is cool! Will take a closer look tomorrow :)

[loxley]

Hey, this is cool! Will take a closer look tomorrow :)

Cool :)

[codecov-commenter]

Codecov Report

Merging #4111 into master will increase coverage by 0.03%.
The diff coverage is 69.44%.

@@            Coverage Diff             @@
##           master    #4111      +/-   ##
==========================================
+ Coverage   42.78%   42.81%   +0.03%     
==========================================
  Files         124      124              
  Lines       18257    18286      +29     
==========================================
+ Hits         7812     7830      +18     
- Misses       9448     9455       +7     
- Partials      997     1001       +4     

Impacted Files	Coverage Δ
reposerver/repository/repository.go	59.53% <44.44%> (-0.37%)	⬇️
cmd/argocd/commands/app.go	5.67% <60.00%> (+0.16%)	⬆️
util/settings/settings.go	42.61% <66.66%> (+0.35%)	⬆️
pkg/apis/application/v1alpha1/types.go	59.01% <100.00%> (ø)
util/helm/cmd.go	44.69% <100.00%> (+2.63%)	⬆️
util/helm/helm.go	66.15% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb216f...6699414. Read the comment docs.

[jannfis]

LGTM, @alexmt do you want to take an additional look please?

[alexmt]

LGTM!

[wrdls]

@alexmt Any idea when this will be included in a release? I checked the 1.7.5 tag but it doesn't seem to be included yet.

I checked https://github.com/argoproj/argo-cd/blob/v1.7.5/cmd/argocd/commands/app.go#L739 for example but version is not in appOptions.