Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Multiple Sources as per ArgoCD v2.6.0 New Field #513

Open
similark opened this issue Dec 29, 2022 · 5 comments · May be fixed by #548 or #578
Open

Support Multiple Sources as per ArgoCD v2.6.0 New Field #513

similark opened this issue Dec 29, 2022 · 5 comments · May be fixed by #548 or #578
Labels
enhancement New feature or request

Comments

@similark
Copy link

Is your feature request related to a problem? Please describe.
ArgoCD v2.6.0-rc1 introduced a new field called sources, which overrides the source field of the application resource. When setting image-updater on such application, we get:
level=warning msg="skipping app 'myapp-staging' of type '' because it's not of supported source type" application=myapp-staging
which indicates that image-updater does not recognize this application as of valid source type.
Describe the solution you'd like
Seems like a minor update could make image-updater aware of this new sources field and apply some logic accordingly

Describe alternatives you've considered
Couldn't find any

Additional context
None

@similark similark added the enhancement New feature or request label Dec 29, 2022
@cregev
Copy link

cregev commented Jan 8, 2023

@jannfis @iamnoah ... we want to contribute to ArgoCD Multiple sources is there anything we can do?

@bentastic27
Copy link

@cregev this is partially due to using an old version of the argo-cd/v2 module.

https://github.com/argoproj-labs/argocd-image-updater/blob/master/go.mod#L7

I tried upping it to 2.6.7 for current and that required some other module changes which looks to have broken other code. I'm a nub at Go, otherwise I'd be taking a closer look at this.

@Tronix117
Copy link

Is this project dead ?
This is a pretty big incompatibility, that is still running for monthes now.

I tried duplicating the first element of sources to source (ignored by argocd 2.6+), but argocd-image-updater still does not pick it.

@jannfis
Copy link
Contributor

jannfis commented Mar 29, 2023

This project is not dead, just hibernating a little at the moment.

The multiple sources feature in Argo CD is in beta-status, and I suppose if you do not use multiple sources in Argo CD, there will be no incompatibility?

@Tronix117
Copy link

Tronix117 commented Mar 30, 2023

You're right, I didn't see it was a beta feature.
In my case, I need to be able to use helm values from the git repo through the use of multiple sources (I don't think it makes a lot of sense that by default values path will be looked for relative to the chart itself, but I may be wrong on that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
5 participants