Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default argocd secret not been used when secret comes from secret template #265

Closed
bitgandtter opened this issue Sep 28, 2021 · 5 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@bitgandtter
Copy link

Describe the bug
When argocd it's setup using the secret template the image updater it's not recognize it, it expect the old format where the secret it's also store on the repository

To Reproduce
Steps to reproduce the behavior:

  • setup argocd with secret template
  • use the argocd default secret

Expected behavior
Image updater to check for credentials on both places the old and the new

Version
Latest argocd and image updater

@bitgandtter bitgandtter added the bug Something isn't working label Sep 28, 2021
@jannfis jannfis added this to the v0.11.0 milestone Sep 28, 2021
@jannfis
Copy link
Contributor

jannfis commented Sep 28, 2021

We haven't released a version with Argo CD v2.1.x libraries pulled in, that's why it is currently not possible to use repository configuration from secrets. An appropriate change is already in master and should be released with the next minor version of Image Updater.

@ghost
Copy link

ghost commented Oct 6, 2021

Is there an estimation to release this fix? It's quite important because otherwise the repo credentials have to be added to the config map.

@jannfis
Copy link
Contributor

jannfis commented Oct 6, 2021

I plan to shift out some of the planned features (which still need work) from v0.11.0 to v0.12 and release what's there now soon. I think both, OCI support and Argo CD upgrade justify a unique release.

So, ETA for v0.11.0 will probably be end of this week or this weekend, dependent on free time available :)

@ghost
Copy link

ghost commented Oct 6, 2021

Great, thanks! Is this issue #268 covered in the next release?

@jannfis
Copy link
Contributor

jannfis commented Dec 16, 2021

This is included in v0.11.0

@jannfis jannfis closed this as completed Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants