fix: make minReplicas required

argoproj-labs · May 19, 2021 · c000e41 · c000e41
1 parent 3089119
commit c000e41
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 1 deletion.
diff --git a/api/v1alpha1/scale.go b/api/v1alpha1/scale.go
@@ -1,7 +1,7 @@
 package v1alpha1
 
 type Scale struct {
-	MinReplicas  int32   `json:"minReplicas,omitempty" protobuf:"varint,1,opt,name=minReplicas"`
+	MinReplicas  int32   `json:"minReplicas" protobuf:"varint,1,opt,name=minReplicas"`
 	MaxReplicas  *uint32 `json:"maxReplicas,omitempty" protobuf:"varint,2,opt,name=maxReplicas"` // takes precedence over min
 	ReplicaRatio uint32  `json:"replicaRatio,omitempty" protobuf:"varint,3,opt,name=replicaRatio"`
 }

diff --git a/config/ci.yaml b/config/ci.yaml
@@ -700,6 +700,8 @@ spec:
                         replicaRatio:
                           format: int32
                           type: integer
+                      required:
+                      - minReplicas
                       type: object
                     serviceAccountName:
                       default: pipeline
@@ -2524,6 +2526,8 @@ spec:
                   replicaRatio:
                     format: int32
                     type: integer
+                required:
+                - minReplicas
                 type: object
               serviceAccountName:
                 default: pipeline

diff --git a/config/crd/bases/dataflow.argoproj.io_pipelines.yaml b/config/crd/bases/dataflow.argoproj.io_pipelines.yaml
@@ -1066,6 +1066,8 @@ spec:
                         replicaRatio:
                           format: int32
                           type: integer
+                      required:
+                      - minReplicas
                       type: object
                     serviceAccountName:
                       default: pipeline

diff --git a/config/crd/bases/dataflow.argoproj.io_steps.yaml b/config/crd/bases/dataflow.argoproj.io_steps.yaml
@@ -1023,6 +1023,8 @@ spec:
                   replicaRatio:
                     format: int32
                     type: integer
+                required:
+                - minReplicas
                 type: object
               serviceAccountName:
                 default: pipeline

diff --git a/config/default.yaml b/config/default.yaml
@@ -700,6 +700,8 @@ spec:
                         replicaRatio:
                           format: int32
                           type: integer
+                      required:
+                      - minReplicas
                       type: object
                     serviceAccountName:
                       default: pipeline
@@ -2524,6 +2526,8 @@ spec:
                   replicaRatio:
                     format: int32
                     type: integer
+                required:
+                - minReplicas
                 type: object
               serviceAccountName:
                 default: pipeline

diff --git a/config/dev.yaml b/config/dev.yaml
@@ -700,6 +700,8 @@ spec:
                         replicaRatio:
                           format: int32
                           type: integer
+                      required:
+                      - minReplicas
                       type: object
                     serviceAccountName:
                       default: pipeline
@@ -2524,6 +2526,8 @@ spec:
                   replicaRatio:
                     format: int32
                     type: integer
+                required:
+                - minReplicas
                 type: object
               serviceAccountName:
                 default: pipeline

diff --git a/config/quick-start.yaml b/config/quick-start.yaml
@@ -700,6 +700,8 @@ spec:
                         replicaRatio:
                           format: int32
                           type: integer
+                      required:
+                      - minReplicas
                       type: object
                     serviceAccountName:
                       default: pipeline
@@ -2524,6 +2526,8 @@ spec:
                   replicaRatio:
                     format: int32
                     type: integer
+                required:
+                - minReplicas
                 type: object
               serviceAccountName:
                 default: pipeline