feat: log backoffSteps, so we can know if an error will retry

argoproj-labs · Aug 2, 2021 · 78e1b32 · 78e1b32
1 parent 4a6837c
commit 78e1b32
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/runner/sidecar/sources.go b/runner/sidecar/sources.go
@@ -52,7 +52,7 @@ func connectSources(ctx context.Context, toMain func(context.Context, []byte) er
 					if err == nil {
 						return nil
 					}
-					logger.Error(err, "⚠ →", "source", sourceName)
+					logger.Error(err, "⚠ →", "source", sourceName, "backoffSteps", backoff.Steps)
 					if backoff.Steps <= 0 {
 						withLock(func() { step.Status.SourceStatuses.IncrErrors(sourceName, replica) })
 						return err
@@ -82,7 +82,7 @@ func connectSources(ctx context.Context, toMain func(context.Context, []byte) er
 		} else if x := s.HTTP; x != nil {
 			sources[sourceName] = httpsource.New(sourceName, f)
 		} else if x := s.S3; x != nil {
-			if y, err := s3source.New(ctx, kubernetesInterface, namespace, pipelineName, stepName, sourceName, *x, f, leadReplica()); err!=nil{
+			if y, err := s3source.New(ctx, kubernetesInterface, namespace, pipelineName, stepName, sourceName, *x, f, leadReplica()); err != nil {
 				return err
 			} else {
 				sources[sourceName] = y