fix: more start-up logging detail (#386)

* fix: more start-up logging detail * fix: clarify confusing logging
argoproj-labs · Sep 29, 2021 · 67f5024 · 67f5024
1 parent f738044
commit 67f5024
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/runner/sidecar/monitor/impl.go b/runner/sidecar/monitor/impl.go
@@ -96,7 +96,7 @@ func (i *impl) commitOffsets(ctx context.Context) {
 	defer i.mu.Unlock()
 	for key, offset := range i.db {
 		if err := i.storage.Set(ctx, key, offset, time.Hour*24*30); err != nil {
-			logger.Error(err, "failed to set bit", "key", key, "offset", offset)
+			logger.Error(err, "failed to commit offset to Redis", "key", key, "offset", offset)
 		}
 	}
 }

diff --git a/runner/sidecar/sidecar.go b/runner/sidecar/sidecar.go
@@ -53,7 +53,8 @@ func Exec(ctx context.Context) error {
 
 	sharedutil.MustUnJSON(os.Getenv(dfv1.EnvStep), &step)
 
-	logger.Info("step", "cluster", cluster, "step", sharedutil.MustJSON(step))
+	logger.Info("resource", "cluster", cluster, "step", stepName, "pipeline", pipelineName)
+	logger.Info("manifest", "step", sharedutil.MustJSON(step))
 
 	if cluster == "" {
 		// this must be configured in the controller