fix: Correct logging of resource names

argoproj-labs · Aug 16, 2021 · 3be7f7f · 3be7f7f
1 parent a81dde5
commit 3be7f7f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/manager/controllers/pipeline_controller.go b/manager/controllers/pipeline_controller.go
@@ -53,7 +53,7 @@ type PipelineReconciler struct {
 // +kubebuilder:rbac:groups=apps,resources=statefulsets,verbs=create;get;delete
 // +kubebuilder:rbac:groups=,resources=secrets,verbs=create;get;delete
 func (r *PipelineReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
-	log := r.Log.WithValues("pipeline", req.NamespacedName)
+	log := r.Log.WithValues("pipeline", req.NamespacedName.String())
 
 	pipeline := &dfv1.Pipeline{}
 	if err := r.Get(ctx, req.NamespacedName, pipeline); err != nil {

diff --git a/manager/controllers/step_controller.go b/manager/controllers/step_controller.go
@@ -74,7 +74,7 @@ func init() {
 // +kubebuilder:rbac:groups=,resources=services,verbs=get;watch;list;create
 // +kubebuilder:rbac:groups="",resources=events,verbs=create;patch
 func (r *StepReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
-	log := r.Log.WithValues("step", req.NamespacedName)
+	log := r.Log.WithValues("step", req.NamespacedName.String())
 
 	step := &dfv1.Step{}
 	if err := r.Get(ctx, req.NamespacedName, step); err != nil {