Skip to content

Commit

Permalink
feat: Add OpenTracing. Fixes #295 (#322)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexec authored Sep 14, 2021
1 parent 8a16a02 commit 0ac1ec2
Show file tree
Hide file tree
Showing 35 changed files with 1,738 additions and 544 deletions.
6 changes: 5 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ CONFIG ?= dev
CRD_OPTIONS ?= "crd:trivialVersions=true"
K3D ?= $(shell [ "`command -v kubectl`" != '' ] && [ "`kubectl config current-context`" = k3d-k3s-default ] && echo true || echo false)
UI ?= false
JAEGER_DISABLED ?= true

# Get the currently used golang install path (in GOPATH/bin, unless GOBIN is set)
ifeq (,$(shell go env GOBIN))
Expand Down Expand Up @@ -85,7 +86,7 @@ $(GOBIN)/goreman:
# Run against the configured Kubernetes cluster in ~/.kube/config
start: deploy build runner $(GOBIN)/goreman wait
kubectl config set-context --current --namespace=argo-dataflow-system
env UI=$(UI) goreman -set-ports=false -logtime=false start
env UI=$(UI) JAEGER_DISABLED=$(JAEGER_DISABLED) goreman -set-ports=false -logtime=false start
wait:
kubectl -n argo-dataflow-system get pod
kubectl -n argo-dataflow-system wait deploy --all --for=condition=available --timeout=2m
Expand Down Expand Up @@ -224,3 +225,6 @@ argocli:
ui:
killall node || true
cd ../../argoproj/argo-workflows && yarn --cwd ui install && yarn --cwd ui start
jaeger:
# expose Jaeger UI: http://localhost:16686
kubectl -n argo-dataflow-system port-forward svc/my-jaeger-query 16686:16686
3 changes: 2 additions & 1 deletion Procfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
controller: source manager.env && go run -race -ldflags="-X 'github.com/argoproj-labs/argo-dataflow/shared/util.version=v0.0.0-latest-0'" ./manager
logs: make logs
argocli: [ "$UI" = true ] && make argocli
ui: [ "$UI" = true ] && make ui
ui: [ "$UI" = true ] && make ui
jaeger: [ "$JAEGER_DISABLED" = false ] && make jaeger
Loading

0 comments on commit 0ac1ec2

Please sign in to comment.