Fixed OtaMagic handling having minus "-" within OtaUrl #3563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curzon01
pushed a commit
to curzon01/Tasmota
that referenced
this pull request
Sep 7, 2018
Fixed OtaMagic handling having minus "-" within OtaUrl
curzon01
pushed a commit
to curzon01/Tasmota
that referenced
this pull request
Sep 7, 2018
6.1.1.9 * Allow user override of define MAX_RULE_TIMERS (arendst#3561) * Allow user override of define MAX_RULE_VARS * Add GPIO options ButtonXn, SwitchXn and CounterXn to select INPUT mode instead of INPUT_PULLUP (arendst#2525) * Fix OtaMagic when file path contains a dash (-) (arendst#3563)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if OtaUrl contains "-" within url (not the filename), OtaMagic fails:
Example
OtaUrl http://tasmota.my-server.local/sonoff.binexceeds 512k so OtaMagic starts work.but it try to load
http://tasmota.my-minimal.bininstead ofhttp://tasmota.my-server.local/sonoff-minimal.binpatch works also with - within firmware name e. g.
OtaUrl http://tasmota.my-server.local/sonoff-nl.bin