Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT add warning if trying to connect without TLS on a port that normally uses TLS #22175

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

s-hadinger
Copy link
Collaborator

@s-hadinger s-hadinger commented Sep 19, 2024

Description:

There was numerous issues raised by users trying to connect on MQTT TLS endpoints using a non-TLS firmware, or forgetting to enable TLS.
This PR adds a warning when trying to connect without TLS to a port that is by convention using TLS: 8883, 443, 8443

Exemple:

00:00:00.193 MQT: Warning non-TLS connection on TLS port 8883

This warning is not displayed in tasmota-minimal to save flash size.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.7
  • The code change is tested and works with Tasmota core ESP32 V.3.0.5
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger s-hadinger merged commit be46b95 into arendst:development Sep 19, 2024
59 checks passed
josef109 pushed a commit to josef109/Tasmota that referenced this pull request Nov 7, 2024
josef109 pushed a commit to josef109/Tasmota that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant