Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quote path #18975

Merged
merged 1 commit into from
Jun 27, 2023
Merged

quote path #18975

merged 1 commit into from
Jun 27, 2023

Conversation

ggottwald
Copy link
Contributor

@ggottwald ggottwald commented Jun 26, 2023

Description:

building an environment from a path that contains whitespaces an error will be thrown.
Path: /Volumes/My Code/Tasmota
Error:

esp_idf_size: error: argument map_file: can't open '/Volumes/My': [Errno 2] No such file or directory: '/Volumes/My'

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.10
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@sfromis
Copy link
Contributor

sfromis commented Jun 26, 2023

You should use path names without spaces. While you may fix one single place, that does not mean that spaces are supported.

@ggottwald
Copy link
Contributor Author

Didn't have any issue in a earlier version with those directories and also not after fixing this. In my opinion directories with spaces should be supported, since we are not in the 90s

@Jason2866
Copy link
Collaborator

Jason2866 commented Jun 26, 2023

Platformio is not designed for whitespaces too. So as sfromis wrote, fix an obvious one and you will run someday in another one. Maybe not so easy to find.
The rule don't use whitespaces and special characters in a file or path is still the way to go.
I will not merge. It is a reminder not to use whitespaces. Thx for the PR which is reminding me to add a check for whitespaces and special chars in Path and stop the compile process with a clear understandable error message.

@Jason2866 Jason2866 added wont/can't fix Result - Requested that can't be fixed/added or it is outside scope good tip Type - Very useful information labels Jun 26, 2023
@ggottwald
Copy link
Contributor Author

Okay, your choice. But I haven't had any problems with platformIO in any other project so far.

@Jason2866
Copy link
Collaborator

Just search for issues in Platformio github. You will find not just one.

@Jason2866
Copy link
Collaborator

Thx, will merge added a warning with #18985 not to have whitespaces in path.

@Jason2866 Jason2866 merged commit 694bebb into arendst:development Jun 27, 2023
@ggottwald ggottwald deleted the patch-1 branch June 27, 2023 19:21
RaphDaMan pushed a commit to RaphDaMan/Tasmota that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good tip Type - Very useful information wont/can't fix Result - Requested that can't be fixed/added or it is outside scope
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants