Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Support for Title (ES, IT, FR) #1726

Closed
wants to merge 1 commit into from
Closed

Language Support for Title (ES, IT, FR) #1726

wants to merge 1 commit into from

Conversation

ascillato
Copy link
Contributor

@ascillato ascillato commented Jan 27, 2018

Added language support on the web page title for spanish, french and italian.

Tested Ok.

if you use spanish, french or italian the title will be displayed [MODULE] [NAME]
if you use others the title will be displayed [NAME] [MODULE]

Added language support on the web page title for spanish, french and italian.

Tested Ok.

if you use spanish, french or italian the title will be displayed [MODULE] [NAME]
if you use others the title will be displayed [NAME] [MODULE]
@ascillato ascillato changed the title Solved Security Issue (#1587) on webserver.ino Language Support for Title (ES, IT, FR) Jan 27, 2018
@arendst
Copy link
Owner

arendst commented Jan 28, 2018

Doesn't work for platformio so I had to use the solution I came up with.

@ascillato
Copy link
Contributor Author

Ok, I understand. So, this is like a workaround until Platform.io has support to #if ?

So, what about this name change:

#ifdef LANGUAGE_MODULE_NAME

for

#ifdef LATIN_LANGUAGES

and also LATIN_LANGUAGES should be on USER_CONFIG.H under localization.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants