Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#undef USE_IR_RECEIVE in user_config_override.h does not disable IRrecv #2718

Closed
TRIROG opened this issue May 13, 2018 · 4 comments
Closed

#undef USE_IR_RECEIVE in user_config_override.h does not disable IRrecv #2718

TRIROG opened this issue May 13, 2018 · 4 comments
Labels
fixed Result - The work on the issue has ended

Comments

@TRIROG
Copy link

TRIROG commented May 13, 2018

Playing around with wemos, minimizing the code footprint i disabled the IR sending with #undef USE_IR_REMOTE and receiving with #undef USE_IR_RECEIVE since i dont need these functions.

However i noticed that there is still option 47 IRrecv available in module configuration, but if understand correctly it shouldnt be, due to #undef USE_IR_RECEIVE in user_config_override.h.
@arendst
Copy link
Owner

arendst commented May 13, 2018

Although the option 47 is still there the code has been disabled.

Removing option 47 also would change the sequence of options available resulting in wrong options selected once USE_IR_RECEIVE is enabled again.

Just ignore it is still there.

@TRIROG
Copy link
Author

TRIROG commented May 13, 2018

can you please confirm
do i need to use #undef USE_IR_RECEIVE if i also use #undef USE_IR_REMOTE in order to reduce the code size for ~9k or is there no need to use #undef USE_IR_RECEIVE becausse disabling IR_REMOTE also disables IR_RECEIVE?

@arendst
Copy link
Owner

arendst commented May 13, 2018

The latter.

You could also try and see what happens....

@TRIROG
Copy link
Author

TRIROG commented May 13, 2018

OK tested, can confirm ... thx

@TRIROG TRIROG closed this as completed May 13, 2018
arendst added a commit that referenced this issue May 17, 2018
@arendst
Admin and some fixes
80ffea0 
5.14.0a
 * Add KNX energy data (#2750)
 * Fix display selection of
un-available GPIO options in Module Configuration webpage (#2718)
 * Fix
IRSend not accepting data value of 0 (#2751)
@arendst arendst added the fixed Result - The work on the issue has ended label May 18, 2018
curzon01 pushed a commit to curzon01/Tasmota that referenced this issue Sep 7, 2018
@arendst
Admin and some fixes
176b9a0 
5.14.0a
 * Add KNX energy data (arendst#2750)
 * Fix display selection of
un-available GPIO options in Module Configuration webpage (arendst#2718)
 * Fix
IRSend not accepting data value of 0 (arendst#2751)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed Result - The work on the issue has ended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TRIROG @arendst