Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard var spelling for reactive power unit #22435

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Use standard var spelling for reactive power unit #22435

merged 1 commit into from
Nov 8, 2024

Conversation

scop
Copy link
Contributor

@scop scop commented Nov 5, 2024

Description:

Note: this is a monkey change, I'm not 100% sure of the effects, please review with care. Home Assistant has switched from VAr to var a while back.

There are a few more occurrences of VAr in the tree, but changing those did not seem safe (or I was even more unsure what doing so might affect than the ones I included here).

Related issue (if applicable): fixes #

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.8
  • The code change is tested and works with Tasmota core ESP32 V.3.1.0.241030
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@Jason2866
Copy link
Collaborator

There is a difference for
Unit name: Var
Unit symbol: var
regarding https://de.wikipedia.org/wiki/Var_(Einheit)
So imho leaving as it is.

@s-hadinger
Copy link
Collaborator

s-hadinger commented Nov 5, 2024

The international symbol is VA not va. I suggest that we stick to international official units.

Edit: hmmm. It seems that the international system actually switched to var.

@arendst arendst merged commit 2f3808a into arendst:development Nov 8, 2024
59 checks passed
@scop scop deleted the reactive-power-unit branch November 14, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants