BLE EQ3 TRV firmware version 1.46 fix #22328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…subscribe on the notify characteristic. So pass false always - then it works with both new and old EQ3 firmware.
josef109
pushed a commit
to josef109/Tasmota
that referenced
this pull request
Nov 7, 2024
…subscribe on the notify characteristic. (arendst#22328) So pass false always - then it works with both new and old EQ3 firmware.
josef109
pushed a commit
to josef109/Tasmota
that referenced
this pull request
Nov 10, 2024
…subscribe on the notify characteristic. (arendst#22328) So pass false always - then it works with both new and old EQ3 firmware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since moving to esp-nimble-cpp, EQ3s with firmware version 1.46 have not worked.
The fix is to pass false in the notify subscription in the last (
response) argument.Description:
Related issue (if applicable): fixes #22267
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass