NeoPool add data validation and statistics #21721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds NeoPool data validation for some sensors and communication statistics (default enabled for ESP32, default disabled for ESP8266, to enable it on ESP8266 define
NEOPOOL_RANGE_CHECKS
andNEOPOOL_CONNSTAT
).Data validation
The following controller measurements are checked against a min/max range, values outside the range are discarded:
Communication statistics
add the following stats to NeoPool SENSOR topic
MBRequests
is the total number of system requestMBNoError
is the total number of system responses without errorMBNoResponse
is the number ofMBRequests
having no repsonseDataOutOfRange
is the total number of values outside the valid rangeMB...
items are Modbus response errors (Modbus error 1..14)Checklist: