Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MCP23S08 (output) support #20971

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

Frank-1964
Copy link
Contributor

Description:

This patch supports the output mode for MCP23S08 gpio expander like used in KMP PRODINo ESP32 Ethernet v1 (https://kmpelectronics.eu/products/prodino-esp32-ethernet-v1)

Checklist:

  • [ x] The pull request is done against the latest development branch
  • [ x] Only relevant files were touched
  • [ x] Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.6
  • [ x] The code change is tested and works with Tasmota core ESP32 V.2.0.14
  • [ x] I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@Jason2866
Copy link
Collaborator

With Tasmota Arduino core 3.0.0, the W5500 Ethernet port can be used from the module.

@barbudor
Copy link
Contributor

With Tasmota Arduino core 3.0.0, the W5500 Ethernet port can be used from the module.

@Jason2866 This PR has nothing to do with Ethernet & W5500

It extend the MCP23xxx GPIO extender driver to another device MCP23S08.
The board listed is just an exemple of a board that using that GPIO extender.
The fact that it also has W5500 is pure fotuity and has nothing to do about it
😄

@Jason2866
Copy link
Collaborator

@barbudor i know the difference ;-) Just noticed with the change from the PR and with newest Core the linked board is fully functional with Tasmota

@arendst arendst merged commit 70bce97 into arendst:development Mar 18, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants