Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rescan and RetryRead to onewire scan for bulletproove onewire #19700

Conversation

chefpro
Copy link
Contributor

@chefpro chefpro commented Oct 7, 2023

Description:

Sometimes onewire sensors get lost on the bus.
To reread lost sensors DS18RetryRead was added. The sensors will "count" times retried when lost.
DS18Rescan can be used if a new sensor was added to the bus or when a sensor was lost in the first scan.

Checklist:

  • [x ] The pull request is done against the latest development branch
  • [ x] Only relevant files were touched
  • [ x] Only one feature/fix was added per PR and the code change compiles without warnings
  • [x ] The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • [x ] The code change is tested and works with Tasmota core ESP32 V.2.0.14
  • [ x] I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst
Copy link
Owner

arendst commented Oct 13, 2023

Thx.

@arendst arendst merged commit 32cbd33 into arendst:development Oct 13, 2023
63 checks passed
@letshin
Copy link

letshin commented Jan 16, 2024

How much effort would this be to extend it for the esp8266 please? Would there be any chance of this happening?

@sfromis
Copy link
Contributor

sfromis commented Jan 16, 2024

Chances are greatly improved if/when someone takes on the task of extending the driver, testing it, and submitting a PR for the project.

@chefpro
Copy link
Contributor Author

chefpro commented Jan 17, 2024

How much effort would this be to extend it for the esp8266 please? Would there be any chance of this happening?

The esp8266 and esp32 use different drivers for ds18x20. So, the effort to implement this is pretty much the same as implementing it for the esp32. Unfortunately i do not have the time to do it and also do not have a spare esp8266 device to test. If you have some programming experience you could look at this PR and adapt it for the esp8266.

@letshin
Copy link

letshin commented Jan 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants