Add MFRC522 support for customizable SPI pins #18711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2.ino RC522_USE_CONFIGURED_SPI_PINS can now be defined so the SPI pins configured in the WebUI are used for communication to the RC522
Added (commented out) RC522_USE_CONFIGURED_SPI_PINS option and a description to my_user_config.h
|
Mhh, is the #ifdef needed in general? There should be no fixed GPIOs in any Tasmota driver! |
|
Agree with @Jason2866. I'll need to dive in why this needs to be fixed the way it is proposed here. |
arendst
added
the
on hold by dev team
|
I see the issue. Will fix in a generic way. Thx for your input. |
arendst
added a commit
that referenced
this pull request
May 23, 2023
Fix ESP32 SPI initialization for MFRC522 (#18711)
|
Thx. Merged in some way. See above. |
|
Oh, nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
(MF)RC522 reader modules cannot be used with e.g. ESP32-cam modules, since the driver uses the default SPI interface.
This code change enables custom builds to use the SPI pins configured via a template (e.g. via web UI)
Checklist: