Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LED PWM ac_dimmer curve was wrongly applied instead of Gamma #18666

Merged
merged 1 commit into from
May 15, 2023

Conversation

s-hadinger
Copy link
Collaborator

@s-hadinger s-hadinger commented May 15, 2023

Description:

Fixes regression introduced in #17177 where ac_dimmer curve was applied instead of Gamma curve. Now the ac_dimmer is only applied if SetOption99 1 is applied.

Fixes #18639

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.9
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger s-hadinger merged commit 81d7785 into arendst:development May 15, 2023
@stefanbode
Copy link
Contributor

Thanks!!

@SteWers
Copy link
Contributor

SteWers commented May 16, 2023

Is analogWrite still suitable at this place since PWM is no longer used with the new driver version?

@s-hadinger
Copy link
Collaborator Author

Is analogWrite still suitable at this place since PWM is no longer used with the new driver version?

I don’t know and I will let @stefanbode check what's needed there for ac dimmer

@stefanbode
Copy link
Contributor

Let me check at the weekend. Right now I'm pretty sure the complete #ifdef zero cross dimmer can be moved away. Anyhow I want to check with a real device if this also works on the init and if there is a sideeffect if the led value is present at this time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants