Set correct OTA URL for all Tasmota build env #18008
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
OTA_URL
is now set in the PIO env. The attempts to do where not working in the past since the define (which is a Macro) was extended wrong.By using the syntax
-D DEFINE_NEEDED='"string"'
the Macro is parsed and extended correctly.All
#define OTA_URL
are removed in source code!All [env) need to have
-DOTA_URL='"path_to_ota_file"'
or an empty entry-DOTA_URL='""'
This Option makes it possible to define more settings without the need of
user_config_override.h
.Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass