Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct OTA URL for all Tasmota build env #18008

Merged
merged 9 commits into from
Feb 20, 2023

Conversation

Jason2866
Copy link
Collaborator

Description:

The OTA_URL is now set in the PIO env. The attempts to do where not working in the past since the define (which is a Macro) was extended wrong.

By using the syntax -D DEFINE_NEEDED='"string"' the Macro is parsed and extended correctly.

All #define OTA_URL are removed in source code!
All [env) need to have -DOTA_URL='"path_to_ota_file"' or an empty entry -DOTA_URL='""'

This Option makes it possible to define more settings without the need of user_config_override.h.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.6
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst arendst merged commit d2f4503 into arendst:development Feb 20, 2023
@barbudor
Copy link
Contributor

Nice 👍

@Jason2866 Jason2866 deleted the pio_ota_url branch February 20, 2023 14:56
ZioFabry pushed a commit to Biomine-Sustainable-Mining/Tasmota that referenced this pull request Feb 25, 2023
* OTA URL Part 1

* typo

* OTA URL Part 2

* OTA URL Part 3

* fix s2 safeboot

* formatting

* rm whitespace

* more beautify

* last whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants