Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flowratemeter add flow amount/duration #16385

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Flowratemeter add flow amount/duration #16385

merged 2 commits into from
Aug 31, 2022

Conversation

curzon01
Copy link
Contributor

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.4.1
  • I accept the CLA.

s-hadinger
s-hadinger reviewed Aug 30, 2022
View reviewed changes
tasmota/tasmota_xsns_sensor/xsns_96_flowratemeter.ino

int32_t flowratemeter_period[MAX_FLOWRATEMETER] = {0};
float flowratemeter_period_avg[MAX_FLOWRATEMETER] = {0};
uint32_t flowratemeter_count[MAX_FLOWRATEMETER] = {0};
volatile uint32_t flowratemeter_last_irq[MAX_FLOWRATEMETER] = {0};
volatile uint32_t flowratemeter_last_irq[MAX_FLOWRATEMETER] = {FLOWRATEMETER_INVALID};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although it was already there, I don't think that volatile does anything here. It's neither a mapped address, nor have we multi-threading in Tasmota.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these vars are use by IRQ function and outside together (like multi-threading)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes! Of course. I forgot about IRQ drivers.

@arendst arendst merged commit dbf0477 into arendst:development Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-hadinger s-hadinger s-hadinger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curzon01 @s-hadinger @arendst