Add support for SGP40 sensor #16341
Merged
Add support for SGP40 sensor #16341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arendst
reviewed
Aug 26, 2022
tools/decode-status.py
Outdated
| @@ -236,7 +236,7 @@ | |||
| "USE_BH1750","USE_VEML6070","USE_ADS1115_I2CDEV","USE_ADS1115", | |||
| "USE_INA219","USE_SHT3X","USE_MHZ19","USE_TSL2561", | |||
| "USE_SENSEAIR","USE_PMS5003","USE_MGS","USE_NOVA_SDS", | |||
| "USE_SGP30","USE_SR04","USE_SDM120","USE_SI1145", | |||
| "USE_SGP30","USE_SGP40","USE_SR04","USE_SDM120","USE_SI1145", | |||
| "USE_SDM630","USE_LM75AD","USE_APDS9960","USE_TM1638" | |||
There was a problem hiding this comment.
You're not supposed to insert ANYTHING here which does not relate to the correct location in file support_features.ino.
In your case you'll need to move the entry down into the new array following USE_DISPLAY_TM1621_SONOFF
arendst
reviewed
Aug 26, 2022
| @@ -825,6 +825,9 @@ void ResponseAppendFeatures(void) | |||
|
|
|||
| static uint32_t feature9 = 0x00000000; | |||
| if (!feature9) { // Only fill this once | |||
| #if defined(USE_I2C) && defined(USE_SGP40) | |||
| feature9 |= 0x00000001; // xsns_98_sgp40.ino | |||
| #endif | |||
| // feature9 |= 0x00000001; | |||
There was a problem hiding this comment.
Remove the above line as you start using it.
Remove used line from support_features.ino
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass