Hardcoding light_scheme numbers in xdrv_light.ino feels like a bug #1463
Labels
stale
Action - Issue left behind - Used by the BOT to call for attention
Comments
arendst
added a commit
that referenced
this issue
Dec 29, 2017
* Add define for additional number of WS2812 schemes (#1463)
arendst
added a commit
that referenced
this issue
Jan 7, 2018
5.11.0 20180107 * Minor webpage HTML optimizations (#1358) * Updated German translation (#1438) * Change Sonoff Pow Energy MQTT data message and consolidate Status 8 into Status 10 * Change ADS1115 default voltage range from +/-2V to +/-6V (#1289) * Change text to Active for 3 minutes (#1364) * Change Wemo SetBinaryState to distinguish from GetBinaryState (#1357) * Change output of HTTP command to valid JSON and Array only (#1363) * Removed all MQTT, JSON and Command language defines from locale files and set fixed to English (#1473) * Renamed commands Color2,3,4 to Color3,4,5 * Fix BME280 calculation (#1051) * Fix Sonoff Bridge missed learned key if learned data contains 0x55 (End of Transmission) flag (#1095, #1294) * Fix PWM initialization in Dimmer/Color mode (#1321) * Fix Wemo Emulation (#1357) * Fix display of build date and time in non-english locale (#1465) * Fix Wemo and Hue emulation by adding M-Search response delay (#1486) * Add libraries Adafruit_BME680-1.0.5, Adafruit_Sensor-1.0.2.02, TasmotaSerial-1.0.0 and TSL2561-Arduino-Library * Add command Color2 to set color while keeping same dimmer value * Add device function pointers * Add support for SenseAir S8 CO2 sensor * Add color led signal to Carbon Dioxide (CO2) sensors using defines CO2_LOW and CO2_HIGH in user_config.h * Add support for Domoticz Air Quality sensor to be used by MH-Z19(B) and SenseAir sensors * Add support for PZEM004T energy sensor * Add support for iTead SI7021 temperature and humidity sensor by consolidating DHT22 into AM2301 and using former DHT22 as SI7021 (#735) * Add support for BME680 using adafruit libraries (#1212) * Add support for MH-Z19(B) CO2 sensor (#561, #1248) * Add multipress support and more user configurable GPIO to Sonoff Dual R2 (#1291) * Add support for TSL2561 using adafruit library (#661, #1311) * Add support for SHT3x (#1314) * Add support for Arilux LC06 (#1414) * Add Italian language file (#1449) * Add 2nd Gen Alexa support to Wemo emulation discovery (#1357, #1450) * Add define for additional number of WS2812 schemes (#1463)
joecotton
pushed a commit
to joecotton/Sonoff-Tasmota
that referenced
this issue
Jan 8, 2018
5.11.0 20180107 * Minor webpage HTML optimizations (arendst#1358) * Updated German translation (arendst#1438) * Change Sonoff Pow Energy MQTT data message and consolidate Status 8 into Status 10 * Change ADS1115 default voltage range from +/-2V to +/-6V (arendst#1289) * Change text to Active for 3 minutes (arendst#1364) * Change Wemo SetBinaryState to distinguish from GetBinaryState (arendst#1357) * Change output of HTTP command to valid JSON and Array only (arendst#1363) * Removed all MQTT, JSON and Command language defines from locale files and set fixed to English (arendst#1473) * Renamed commands Color2,3,4 to Color3,4,5 * Fix BME280 calculation (arendst#1051) * Fix Sonoff Bridge missed learned key if learned data contains 0x55 (End of Transmission) flag (arendst#1095, arendst#1294) * Fix PWM initialization in Dimmer/Color mode (arendst#1321) * Fix Wemo Emulation (arendst#1357) * Fix display of build date and time in non-english locale (arendst#1465) * Fix Wemo and Hue emulation by adding M-Search response delay (arendst#1486) * Add libraries Adafruit_BME680-1.0.5, Adafruit_Sensor-1.0.2.02, TasmotaSerial-1.0.0 and TSL2561-Arduino-Library * Add command Color2 to set color while keeping same dimmer value * Add device function pointers * Add support for SenseAir S8 CO2 sensor * Add color led signal to Carbon Dioxide (CO2) sensors using defines CO2_LOW and CO2_HIGH in user_config.h * Add support for Domoticz Air Quality sensor to be used by MH-Z19(B) and SenseAir sensors * Add support for PZEM004T energy sensor * Add support for iTead SI7021 temperature and humidity sensor by consolidating DHT22 into AM2301 and using former DHT22 as SI7021 (arendst#735) * Add support for BME680 using adafruit libraries (arendst#1212) * Add support for MH-Z19(B) CO2 sensor (arendst#561, arendst#1248) * Add multipress support and more user configurable GPIO to Sonoff Dual R2 (arendst#1291) * Add support for TSL2561 using adafruit library (arendst#661, arendst#1311) * Add support for SHT3x (arendst#1314) * Add support for Arilux LC06 (arendst#1414) * Add Italian language file (arendst#1449) * Add 2nd Gen Alexa support to Wemo emulation discovery (arendst#1357, arendst#1450) * Add define for additional number of WS2812 schemes (arendst#1463)
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
stale
|
This issue will be auto-closed because there hasn't been any activity for a few months. Feel free to open a new one if you still experience this problem. |
curzon01
pushed a commit
to curzon01/Tasmota
that referenced
this issue
Sep 6, 2018
* Add define for additional number of WS2812 schemes (arendst#1463)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are several places in xdrv_light.ino where max_scheme is calculated from LS_MAX +7
This has bitten me, as I tried adding another scheme - but having to change the code in 2-3 places.
Proposal: replace the +7 with a proper #define or an #enum like for LS_MAX.
I'm happy to submit a patch, if a way is preferred
(I added an enum in sonoff.h so far, but a define would also work).
this is only valid for WS2812
The text was updated successfully, but these errors were encountered: