Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support XML string and file path for NDAttributesFile #503

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Support XML string and file path for NDAttributesFile #503

merged 1 commit into from
Feb 9, 2024

Conversation

marcelldls
Copy link
Contributor

closes #502 @coretl Tested against the example XML from ADCore/ADApp/ADSrc/asynNDArrayDriver.cpp

@coretl
Copy link

coretl commented Feb 9, 2024

@MarkRivers are we ok to merge this?

@MarkRivers
Copy link
Member

Yes, doing it now.

@MarkRivers MarkRivers merged commit 5f0f202 into areaDetector:master Feb 9, 2024
7 checks passed
@MarkRivers MarkRivers mentioned this pull request Feb 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coretl coretl coretl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support XML string as well as file path in NDAttributesFile
3 participants
@marcelldls @coretl @MarkRivers