Add convenience function for "type" schema result parsing

The JSON schema validation result parsing infrastructure provides general purpose capabilities for identifying the
instance and schema pointers related to a validation failure. However, when a specific type of schema keyword is used in
multiple places, it is convenient to create a dedicated wrapper function to facilitate that use case. Although present in
the schemas for the sake of completeness, there are no rules for checking schema validation results for the "type"
keyword because the Arduino "properties" data format treats all values as strings. For this reason, there was no convenience
function for this keyword. Due to using the JSON data format, which allows for any type, there will be type checking
schema-based rules for the package index project type. So it now becomes worthwhile having a convenience parsing function
for the "type" keyword.

Author: per1234

internal/rule/schema/parsevalidationresult.go

@@ -54,6 +54,11 @@ func PropertyDependenciesMissing(propertyName string, validationResult Validatio
 	return ValidationErrorMatch("", "/dependencies/"+propertyName+"/[0-9]+$", "", "", validationResult)
 }
 
+// PropertyTypeMismatch returns whether the given property has incorrect type.
+func PropertyTypeMismatch(propertyName string, validationResult ValidationResult) bool {
+	return ValidationErrorMatch("^#/"+propertyName+"$", "/type$", "", "", validationResult)
+}
+
 // PropertyFormatMismatch returns whether the given property has incorrect format.
 func PropertyFormatMismatch(propertyName string, validationResult ValidationResult) bool {
 	return ValidationErrorMatch("^#/"+propertyName+"$", "/format$", "", "", validationResult)

internal/rule/schema/schema_test.go

@@ -153,6 +153,29 @@ func TestPropertyEnumMismatch(t *testing.T) {
 	assert.True(t, PropertyEnumMismatch("property3", validationResult))
 }
 
+func TestPropertyTypeMismatch(t *testing.T) {
+	propertyName := "TestPropertyTypeMismatch"
+	instanceTemplate := `
+{
+	"%s": "foo"
+}
+`
+	rawInstance := fmt.Sprintf(instanceTemplate, propertyName)
+	var instance map[string]interface{}
+	json.Unmarshal([]byte(rawInstance), &instance)
+
+	assert.False(t, PropertyTypeMismatch(propertyName, Validate(instance, validSchemaWithReferences)), "Property type is correct")
+
+	// Change property to incorrect type.
+	pointerString := "/" + propertyName
+	pointer, err := gojsonpointer.NewJsonPointer(pointerString)
+	require.NoError(t, err)
+	_, err = pointer.Set(instance, 1)
+	require.NoError(t, err)
+
+	assert.True(t, PropertyTypeMismatch(propertyName, Validate(instance, validSchemaWithReferences)), "Property type is incorrect")
+}
+
 func TestPropertyFormatMismatch(t *testing.T) {
 	propertyName := "TestPropertyFormatMismatch"
 	instanceTemplate := `

internal/rule/schema/testdata/bindata.go

@@ -138,6 +138,11 @@ var _referencedSchema2Json = []byte(`{
         ]
       }
     },
+    "TestPropertyTypeMismatch": {
+      "object": {
+        "type": "string"
+      }
+    },
     "TestPropertyFormatMismatch": {
       "object": {
         "format": "uri"
@@ -223,6 +228,13 @@ var _validSchemaWithReferencesJson = []byte(`{
         }
       ]
     },
+    "TestPropertyTypeMismatch": {
+      "allOf": [
+        {
+          "$ref": "referenced-schema-2.json#/definitions/TestPropertyTypeMismatch/object"
+        }
+      ]
+    },
     "TestPropertyFormatMismatch": {
       "allOf": [
         {

internal/rule/schema/testdata/input/referenced-schema-2.json

@@ -26,6 +26,11 @@
         ]
       }
     },
+    "TestPropertyTypeMismatch": {
+      "object": {
+        "type": "string"
+      }
+    },
     "TestPropertyFormatMismatch": {
       "object": {
         "format": "uri"

internal/rule/schema/testdata/input/valid-schema-with-references.json

@@ -31,6 +31,13 @@
         }
       ]
     },
+    "TestPropertyTypeMismatch": {
+      "allOf": [
+        {
+          "$ref": "referenced-schema-2.json#/definitions/TestPropertyTypeMismatch/object"
+        }
+      ]
+    },
     "TestPropertyFormatMismatch": {
       "allOf": [
         {