Commit b9721b5
committed
Define macOS code signing identity via AC_APPLICATION_IDENTITY environment variable
The release workflows use the "Gon" tool to sign and notarize the macOS builds.
The signing identity of the code signing certificate must be provided to the tool. Previously, this was hardcoded into
the workflows. That was not ideal because the workflows are intended to be generally applicable to any project,
including 3rd party projects which will have a different signing identity from that of Arduino's certificates.
In addition to posing an inconvenience to hard forks, the previous hardcoding also made it more difficult for community
contributors to validate changes to the release system in their fork in preparation for submitting a pull request to
Arduino's repository.
In addition to the configuration file that was previously used to configure the identity, Gon supports configuration via
environment variables. Environment variables are already used for the other certificate-specific configuration. The
reason an environment variable was not done for the identity is simply that Gon did not have support for doing so at the
time the notarization system was developed. However, it is supported from version 0.0.28.
Since this is public information, a repository variable (as opposed to the GitHub Actions secrets mechanism used by the
workflow for the non-public data) is used to configure the identity via the repository settings. This will make it
possible to run the workflow with any suitable certificate and credentials, without any changes to the workflow code.
---
Even though it no longer contains any data, it was necessary to leave the empty `sign` block in the **Gon**
configuration file, as the presence of this block is required by the tool:
```
❗️ `sign` configuration required with `source` set
When you set the `source` configuration, you must also specify the
`sign` configuration to sign the input files.
```1 parent c2a5278 commit b9721b5
File tree
2 files changed
+4
-6
lines changed- .github/workflows
2 files changed
+4
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
168 | | - | |
169 | | - | |
170 | | - | |
| 168 | + | |
171 | 169 | | |
172 | 170 | | |
173 | 171 | | |
| |||
178 | 176 | | |
179 | 177 | | |
180 | 178 | | |
| 179 | + | |
181 | 180 | | |
182 | 181 | | |
183 | 182 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
168 | | - | |
169 | | - | |
170 | | - | |
| 168 | + | |
171 | 169 | | |
172 | 170 | | |
173 | 171 | | |
| |||
178 | 176 | | |
179 | 177 | | |
180 | 178 | | |
| 179 | + | |
181 | 180 | | |
182 | 181 | | |
183 | 182 | | |
| |||
0 commit comments