improved error messages parsing (#2782)

* improved regexp to also parse error messages with single quotes around header file name

* make regexp more specific, add test

* remove GH test failing escaped quotation marks

* fix formatting

* Use a more strict regexp / fix unit-test

---------

Co-authored-by: Cristian Maglie <[email protected]>

Author: dennisppaul

internal/arduino/builder/internal/detector/detector.go

@@ -477,8 +477,7 @@ func (l *SketchLibrariesDetector) failIfImportedLibraryIsWrong() error {
 	return nil
 }
 
-// includeRegexp fixdoc
-var includeRegexp = regexp.MustCompile("(?ms)^\\s*#[ \t]*include\\s*[<\"](\\S+)[\">]")
+var includeRegexp = regexp.MustCompile(`(?ms)^\s*[0-9 |]*\s*#[ \t]*include\s*[<"](\S+)[">]`)
 
 // IncludesFinderWithRegExp fixdoc
 func IncludesFinderWithRegExp(source string) string {

internal/arduino/builder/internal/detector/detector_test.go

@@ -75,3 +75,13 @@ func TestIncludesFinderWithRegExpPaddedIncludes4(t *testing.T) {
 
 	require.Equal(t, "register.h", include)
 }
+
+func TestIncludesFinderWithRegExpPaddedIncludes5(t *testing.T) {
+	output := "/some/path/sketch.ino:23:42: fatal error: 'Foobar.h' file not found\n" +
+		"   23 | #include \"Foobar.h\"\n" +
+		"      |          ^~~~~~~~~~\n"
+
+	include := detector.IncludesFinderWithRegExp(output)
+
+	require.Equal(t, "Foobar.h", include)
+}