Portenta H7M7 support for analogWrite/analogRead

@mjs513 and I added/modified the device tree for this board, with the tables to support PWM (analogWrite) and analogRead on some of the Analog pins.

Note: there are some issues with A3/A4 in that those pins are also on the same pins that support SPI.
And when SPI is enabled, the GPIOC pin configuration is setup by the device tree to be MODER to be set for Alternat function and their AF set to 5.  The analogRead code does not does not update these tables and as
such analogRead fails.

We found that if y ou disable SPI then they work better.

I currently left the SPI enabled.  Probably need to add something that when analogRead is called that it updates the GPIO registers to make it work.

I am ecurrently experimenting with a hack in my test sketch that appears to change the MODER of those pins back to 3, but so far that does not appear to be sufficent:
```
#include "zephyrInternal.h"
 static const struct gpio_dt_spec arduino_pins[] = {DT_FOREACH_PROP_ELEM_SEP(
   DT_PATH(zephyr_user), digital_pin_gpios, GPIO_DT_SPEC_GET_BY_IDX, (, ))};

  void pinModeAnalog(pin_size_t pinNumber) {
     gpio_pin_configure_dt(&arduino_pins[pinNumber],
                           GPIO_INPUT /*| GPIO_ACTIVE_HIGH */ | GPIO_MODE_ANALOG);
 }
```

On the analogWrites, this code has optionally in place that allows duplicate pins in the device tree GPIO list,  by changing how I read in the PWM table from the Tree, instead of summing all of the matches in the GPIO tree, it instead saves the GPIO Port and pin number and uses them for the compare.

Again this depends on if we wish for the Pin numbers for the functions like digitalRead/digitalWrite to match those used by the MBED version.   I still have the last 3 truncated K5-K7 which are used by the LEDs and fault
but depending on directions, can find other solutions.

Author: KurtE

cores/arduino/zephyrCommon.cpp

@@ -140,6 +140,29 @@ const struct pwm_dt_spec arduino_pwm[] =
 	{ DT_FOREACH_PROP_ELEM(DT_PATH(zephyr_user), pwms, PWM_DT_SPEC) };
 
 /* pwm-pins node provides a mapping digital pin numbers to pwm channels */
+#if 1
+static const struct gpio_dt_spec arduino_pwm_pins[] = {DT_FOREACH_PROP_ELEM_SEP(
+  DT_PATH(zephyr_user), pwm_pin_gpios, GPIO_DT_SPEC_GET_BY_IDX, (, ))};
+
+size_t pwm_pin_index(pin_size_t pinNumber) {
+  printk("pwm_pin_index: %u: ", pinNumber);
+  if (pinNumber >= ARRAY_SIZE(arduino_pins)) {
+    return (size_t)-1;
+  }
+  printk("(%p %u):", arduino_pins[pinNumber].port, arduino_pins[pinNumber].pin);
+  for(size_t i=0; i<ARRAY_SIZE(arduino_pwm_pins); i++) {
+    printk(" [%p,%u]", arduino_pwm_pins[i].port, arduino_pwm_pins[i].pin);
+    if ((arduino_pwm_pins[i].port == arduino_pins[pinNumber].port) && (arduino_pwm_pins[i].pin == arduino_pins[pinNumber].pin)) {
+      printk("\n");
+      return i;
+    }
+  }
+      printk("\n");
+  return (size_t)-1;
+}
+
+
+#else  
 const pin_size_t arduino_pwm_pins[] =
 	{ DT_FOREACH_PROP_ELEM(DT_PATH(zephyr_user), pwm_pin_gpios, PWM_PINS) };
 
@@ -151,7 +174,7 @@ size_t pwm_pin_index(pin_size_t pinNumber) {
   }
   return (size_t)-1;
 }
-
+#endif
 #endif //CONFIG_PWM
 
 #ifdef CONFIG_ADC
@@ -293,7 +316,12 @@ void delay(unsigned long ms) { k_sleep(K_MSEC(ms)); }
 void delayMicroseconds(unsigned int us) { k_sleep(K_USEC(us)); }
 
 unsigned long micros(void) {
-  return k_cyc_to_us_floor32(k_cycle_get_64());
+
+#ifdef CONFIG_TIMER_HAS_64BIT_CYCLE_COUNTER
+   return k_cyc_to_us_floor32(k_cycle_get_64());
+#else
+   return k_cyc_to_us_floor32(k_cycle_get_32());
+#endif   
 }
 
 unsigned long millis(void) { return k_uptime_get_32(); }

loader/boards/arduino_portenta_h7_m7.conf

@@ -24,8 +24,8 @@ CONFIG_SHELL_STACK_SIZE=32768
 CONFIG_MAIN_STACK_SIZE=32768
 CONFIG_LLEXT_HEAP_SIZE=128
 
-#CONFIG_ADC=y
-#CONFIG_PWM=y
+CONFIG_ADC=y
+CONFIG_PWM=y
 CONFIG_DMA=y
 CONFIG_MEMC=y
 CONFIG_SPI_ASYNC=y

loader/boards/arduino_portenta_h7_m7.overlay

@@ -34,24 +34,169 @@
 };
 
 &spi2 {
-	status = "okay";
+	status = "disabled";
 	pinctrl-0 = <&spi2_sck_pi1
 		     &spi2_miso_pc2 &spi2_mosi_pc3>;
 	pinctrl-names = "default";
 };
 
-&dmamux1 {
+&timers1 {
 	status = "okay";
+	st,prescaler = <0>;
+
+	pwm1: pwm {
+		status = "okay";
+		pinctrl-0 = <&tim1_ch1_pk1 &tim1_ch2_pj11>;
+		pinctrl-names = "default";
+	};
 };
 
-&dma1 {
+&timers3 {
+	status = "okay";
+	st,prescaler = <100>;
+
+	pwm3: pwm {
+		status = "okay";
+		pinctrl-0 = <&tim3_ch1_pc6 &tim3_ch2_pc7>;
+		pinctrl-names = "default";
+	};
+};
+
+&timers8 {
+	status = "okay";
+	st,prescaler = <100>;
+
+	pwm8: pwm {
+		status = "okay";
+		pinctrl-0 = <&tim8_ch3n_ph15 &tim8_ch2_pj10 &tim8_ch2n_pj7>;
+		pinctrl-names = "default";
+	};
+};
+
+&timers12 {
 	status = "okay";
+	st,prescaler = <100>;
+
+	pwm12: pwm {
+		status = "okay";
+		pinctrl-0 = <&tim12_ch1_ph6>;
+		pinctrl-names = "default";
+	};
+};
+
+&pwm1 {
+	/* Use the pwmclock node to start the clock generation */
+	pwmclock: pwmclock {
+		status = "okay";
+		compatible = "pwm-clock";
+		clock-frequency = <0>;
+		#clock-cells = <1>;
+		pwms = <&pwm1 2 PWM_HZ(12000000) PWM_POLARITY_NORMAL>;
+	};
 };
 
 &rng {
 	status = "okay";
 };
 
+&dmamux1 {
+    status = "okay";
+};
+
+&dma1 {
+	status = "okay";
+};
+
+
+&adc1 {
+	pinctrl-0 = <&adc1_inp12_pc2
+    &adc1_inp13_pc3
+    &adc1_inp18_pa4
+    &adc1_inp3_pa6
+		&adc1_inp0_pa0_c
+		&adc1_inp1_pa1_c>;
+	pinctrl-names = "default";
+	st,adc-clock-source = <SYNC>;
+	st,adc-prescaler = <4>;
+	status = "okay";
+
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	channel@c {
+		reg = <12>;
+		zephyr,gain = "ADC_GAIN_1";
+		zephyr,reference = "ADC_REF_INTERNAL";
+		zephyr,acquisition-time = <ADC_ACQ_TIME_MAX>;
+		zephyr,resolution = <16>;
+	};
+	channel@d {
+		reg = <13>;
+		zephyr,gain = "ADC_GAIN_1";
+		zephyr,reference = "ADC_REF_INTERNAL";
+		zephyr,acquisition-time = <ADC_ACQ_TIME_MAX>;
+		zephyr,resolution = <16>;
+	};
+	channel@12 {
+		reg = <18>;
+		zephyr,gain = "ADC_GAIN_1";
+		zephyr,reference = "ADC_REF_INTERNAL";
+		zephyr,acquisition-time = <ADC_ACQ_TIME_MAX>;
+		zephyr,resolution = <16>;
+	};
+	channel@3 {
+		reg = <3>;
+		zephyr,gain = "ADC_GAIN_1";
+		zephyr,reference = "ADC_REF_INTERNAL";
+		zephyr,acquisition-time = <ADC_ACQ_TIME_MAX>;
+		zephyr,resolution = <16>;
+	};
+
+	/* PA0_C and PA1_C */
+	channel@0 {
+		reg = <0>;
+		zephyr,gain = "ADC_GAIN_1";
+		zephyr,reference = "ADC_REF_INTERNAL";
+		zephyr,acquisition-time = <ADC_ACQ_TIME_MAX>;
+		zephyr,resolution = <16>;
+	};
+	channel@1 {
+		reg = <1>;
+		zephyr,gain = "ADC_GAIN_1";
+		zephyr,reference = "ADC_REF_INTERNAL";
+		zephyr,acquisition-time = <ADC_ACQ_TIME_MAX>;
+		zephyr,resolution = <16>;
+	};
+};
+
+&adc3 {
+	pinctrl-0 = <&adc3_inp0_pc2_c
+		&adc3_inp1_pc3_c>;
+	pinctrl-names = "default";
+	st,adc-clock-source = <SYNC>;
+	st,adc-prescaler = <4>;
+	status = "okay";
+
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	channel@0 {
+		reg = <0>;
+		zephyr,gain = "ADC_GAIN_1";
+		zephyr,reference = "ADC_REF_INTERNAL";
+		zephyr,acquisition-time = <ADC_ACQ_TIME_MAX>;
+		zephyr,resolution = <16>;
+	};
+	channel@1 {
+		reg = <1>;
+		zephyr,gain = "ADC_GAIN_1";
+		zephyr,reference = "ADC_REF_INTERNAL";
+		zephyr,acquisition-time = <ADC_ACQ_TIME_MAX>;
+		zephyr,resolution = <16>;
+	};
+};
+
+
 / {
 	chosen {
 		zephyr,console = &usart6;
@@ -293,20 +438,60 @@
   					<&gpiok 1 0>,
   					<&gpiok 2 0>,
   					<&gpiok 3 0>,
-  					<&gpiok 4 0>,
-  					<&gpiok 5 0>,
-  					<&gpiok 6 0>,
-  					<&gpiok 7 0>;
+  					<&gpiok 4 0>;
+  					
+					/* commented out for now to allow LEDs to work
+					/* <&gpiok 5 0>, */
+  					/* <&gpiok 6 0>, */
+  					/* <&gpiok 7 0>; */
 
 
 
 		builtin-led-gpios = <&gpiok 5 GPIO_ACTIVE_LOW>,
-                        <&gpiok 6 GPIO_ACTIVE_LOW>,
-                        <&gpiok 7 GPIO_ACTIVE_LOW>;
-
+					<&gpiok 6 GPIO_ACTIVE_LOW>,
+					<&gpiok 7 GPIO_ACTIVE_LOW>;
+                        
+		pwm-pin-gpios =	//<&gpioa 8 0>,
+					<&gpioc 6 0>,
+					<&gpioc 7 0>,
+					//<&gpiog 7 0>,
+					<&gpioj 11 0>,
+					<&gpiok 1 0>,
+					<&gpioh 15 0>,
+					<&gpioj 7 0>,
+					<&gpioj 10 0>,
+					<&gpioh 6 0>;
+                    
+		adc-pin-gpios =	<&gpioz 0 0>,			/* analog only */
+				<&gpioz 1 0>,			/* analog only */
+				<&gpioz 2 0>,			/* analog only */
+				<&gpioz 3 0>,			/* analog only */
+				<&gpioc 2 0>,
+				<&gpioc 3 0>,
+				<&gpioa 4 0>,
+				<&gpioa 6 0>;
+                    
 		serials = <&cdc_acm_uart0>,<&usart6>, <&usart1>, <&uart4>;
 		cdc-acm = <&cdc_acm_uart0>;
 		i2cs = <&i2c3>, <&i2c1>, <&i2c4>;
 		spis = <&spi2>;
+		pwms = //<&pwm8 1 PWM_HZ(500) PWM_POLARITY_NORMAL>,
+				<&pwm3 1 PWM_HZ(500) PWM_POLARITY_NORMAL>,
+				<&pwm3 2 PWM_HZ(500) PWM_POLARITY_NORMAL>,
+				<&pwm1 2 PWM_HZ(12000000) PWM_POLARITY_NORMAL>, 
+				<&pwm1 1 PWM_HZ(5000) PWM_POLARITY_NORMAL>,
+				<&pwm8 1 PWM_HZ(500) PWM_POLARITY_INVERTED>,
+				<&pwm8 3 PWM_HZ(500) PWM_POLARITY_INVERTED>,
+				<&pwm8 2 PWM_HZ(500) PWM_POLARITY_NORMAL>,
+				<&pwm12 1 PWM_HZ(500) PWM_POLARITY_NORMAL>;
+          
+  io-channels =	<&adc1 0>,
+				<&adc1 1>,
+				<&adc3 0>,
+				<&adc3 1>,
+				<&adc1 12>,
+				<&adc1 13>,
+				<&adc1 18>,
+				<&adc1 3>;        
 	};
 };

variants/arduino_portenta_h7/pure_analog_pins.cpp

@@ -0,0 +1,17 @@
+#include "pure_analog_pins.h"
+
+#undef A0
+#undef A1
+#undef A2
+#undef A3
+
+PureAnalogPin  A0_PURE(0);
+PureAnalogPin  A1_PURE(1);
+PureAnalogPin  A2_PURE(2);
+PureAnalogPin  A3_PURE(3);
+
+int getAnalogReadResolution();
+
+int analogRead(PureAnalogPin pin) {
+  return ::analogRead(A0 + pin.get());
+}

variants/arduino_portenta_h7/pure_analog_pins.h

@@ -0,0 +1,57 @@
+#ifndef _PURE_ANALOG_PINS_
+#define _PURE_ANALOG_PINS_
+
+/******************************************************************************
+ * INCLUDE
+ ******************************************************************************/
+
+#include "Arduino.h"
+
+/******************************************************************************
+ * PREPROCESSOR-MAGIC
+ ******************************************************************************/
+
+#define PURE_ANALOG_AS_DIGITAL_ATTRIBUTE __attribute__ ((error("Can't use pins A0-A3 as digital")))
+
+/******************************************************************************
+ * TYPEDEF
+ ******************************************************************************/
+
+class PureAnalogPin {
+public:
+	PureAnalogPin(int _pin) : pin(_pin) {};
+	int get() {
+		return pin;
+	};
+	bool operator== (PureAnalogPin const & other) const {
+		return pin == other.pin;
+	}
+	//operator int() = delete;
+	__attribute__ ((error("Change me to a #define"))) operator int();
+private:
+	int pin;
+};
+
+extern PureAnalogPin  A0_PURE;
+extern PureAnalogPin  A1_PURE;
+extern PureAnalogPin  A2_PURE;
+extern PureAnalogPin  A3_PURE;
+
+#define A0  A0_PURE
+#define A1  A1_PURE
+#define A2  A2_PURE
+#define A3  A3_PURE
+
+/******************************************************************************
+ * FUNCTION DECLARATION
+ ******************************************************************************/
+
+void      PURE_ANALOG_AS_DIGITAL_ATTRIBUTE pinMode     (PureAnalogPin pin, PinMode mode);
+PinStatus PURE_ANALOG_AS_DIGITAL_ATTRIBUTE digitalRead (PureAnalogPin pin);
+void      PURE_ANALOG_AS_DIGITAL_ATTRIBUTE digitalWrite(PureAnalogPin pin, PinStatus value);
+int       analogRead  (PureAnalogPin pin);
+void      PURE_ANALOG_AS_DIGITAL_ATTRIBUTE analogWrite (PureAnalogPin pin, int value);
+
+#undef PURE_ANALOG_AS_DIGITAL_ATTRIBUTE
+
+#endif /* _PURE_ANALOG_PINS_ */

variants/arduino_portenta_h7/variant.h

@@ -3,6 +3,7 @@
  *
  * SPDX-License-Identifier: Apache-2.0
  */
+#include "pure_analog_pins.h"
 
 // TODO: correctly handle these legacy defines
 #define MOSI    0