Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded digest algorithm value for SE05x is inconsistent with SE05x default configuration. #218

Closed
lagosantol opened this issue Dec 20, 2023 · 1 comment
Closed

Hardcoded digest algorithm value for SE05x is inconsistent with SE05x default configuration. #218

lagosantol opened this issue Dec 20, 2023 · 1 comment
Assignees
@pennam
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@lagosantol
Copy link
Contributor

https://github.com/arduino/ArduinoCore-renesas/blob/c0f158f1e0a536de76a06163bc14d19f649ba33a/extras/tls/mbedtls_alt/ecdsa_se05x.c#L171C45-L171C45

The actual algorithm to use should depend on the input size.
(20 bytes means SHA1, 32 bytes means SHA256, etc...)
@pennam pennam self-assigned this Dec 20, 2023
@pennam pennam mentioned this issue Dec 20, 2023
Closed
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Dec 20, 2023
@per1234 per1234 linked a pull request Dec 20, 2023 that will close this issue
Fixed hash algo to be selected based on input and not hardcoded #219
Closed
@pennam
Copy link
Contributor

pennam commented Jun 12, 2024

fixed with #229

@pennam pennam closed this as completed Jun 12, 2024
@per1234 per1234 added the conclusion: resolved Issue was resolved label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pennam pennam

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed hash algo to be selected based on input and not hardcoded lagosantol/ArduinoCore-renesas
3 participants
@per1234 @pennam @lagosantol