Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for perseus v0.4.0-beta.1 needed in examples/simple #5

Closed
allen-woods opened this issue Jun 23, 2022 · 3 comments
Closed

Support for perseus v0.4.0-beta.1 needed in examples/simple #5

allen-woods opened this issue Jun 23, 2022 · 3 comments

Comments

@allen-woods
Copy link

Please provide a version of examples/simple that can be compiled on perseus v0.4.x and later.

Current dependencies on perseus-size-opt v0.1.7 and later cause cargo to pull two versions of certain crates when compiling using the current pre-release beta of perseus when following Docker Deployment instructions.

Thanks! 😺

@arctic-hen7
Copy link
Owner

I'm actually going to deprecate this plugin entirely with v0.4.0-beta.2, which removes .perseus/, and thus the need for this plugin. I would advise you leave this plugin entirely out of the v0.4.x Docker deployments. The deprecation message will go up once the new version is out (still waiting on a few things from Sycamore).

My reasoning for not updating the plugin is that its whole purpose is to simplify updating .perseus/Cargo.toml, which was hidden from the user. With the new architecture, there's just the user's own usual Cargo.toml, which means they can more easily control the optimizations they make.

Supporting the first beta version is not really worth doing if the second will deprecate it (since there's no distinction between beta versions in the Perseus docs). That said, I can still add support for the first beta if you want!

@allen-woods
Copy link
Author

Supporting the first beta version is not really worth doing if the second will deprecate it (since there's no distinction between beta versions in the Perseus docs). That said, I can still add support for the first beta if you want!

I agree that it wouldn't make sense to resolve this issue as requested when this plugin is being deprecated soon.

My request to make the example available for 0.4.0-beta.1 was simply to standardize existing deployment docs for docker across currently available releases.

I'll make adjustments to migrate away from perseus-size-opt in 0.4.x and later.
Thanks!

@arctic-hen7
Copy link
Owner

No problem! Note that the next beta of Perseus will come out probably today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants