Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rollup): Fail compilation on type check failure #68

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

blaine-arcjet
Copy link
Contributor

It seems that, by default, rollup does not exit with an error if the TypeScript code fails to type check. Setting the noEmitOnError option to true will cause it to exit if the TS fails to build.

@blaine-arcjet blaine-arcjet merged commit b9a373b into main Dec 15, 2023
7 checks passed
@blaine-arcjet blaine-arcjet deleted the phated/rollup-fail-on-type-check branch December 15, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants