-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show type warning if you provide allow and deny to detectBot #1502
Comments
This is weird because there should be a type warning 🤔 |
Ah maybe because it's a js example, not ts? |
Correct, there's no type checking in JS |
You can see that I needed to use |
I didn't even look at the extension, just assumed it was TS...I never write pure JS 😅 |
Any example that runs in just Node without an explicit CLI tool to build the application is pure JS because otherwise adding a build step with all the dependencies takes away from the purity of the example. Perhaps we need to spend time on #72 so we can have consolidated examples. |
We throw if you provide both
allow
anddeny
configs fordetectBot
, but it would be helpful to show a type warning as well:The text was updated successfully, but these errors were encountered: