Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analyze): Ensure headers are serialized correctly #1435

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

blaine-arcjet
Copy link
Contributor

Closes #1434

This fixes an issue with generating a fingerprint using headers because the ArcjetHeaders or Headers would not be serialized with JSON.stringify.

I also added a test that produced an empty-string fingerprint before the fix was implemented.

@blaine-arcjet blaine-arcjet requested a review from a team as a code owner August 28, 2024 16:27
Copy link

trunk-io bot commented Aug 28, 2024

😎 Merged successfully - details.

@trunk-io trunk-io bot merged commit 0319412 into main Aug 28, 2024
22 checks passed
@trunk-io trunk-io bot deleted the phated/fix-analyze-request-stringify branch August 28, 2024 16:35
trunk-io bot pushed a commit that referenced this pull request Sep 2, 2024
Automatically generated with [Release Please](https://github.com/googleapis/release-please).
---


<details><summary>@arcjet/analyze: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/analyze-v1.0.0-alpha.23) (2024-09-02)


### 🪲 Bug Fixes

* **analyze:** Ensure headers are serialized correctly ([#1435](#1435)) ([0319412](0319412))
* Ensure instantiation throws if WebAssembly is unavailable ([#1458](#1458)) ([0edfd45](0edfd45))


### 🧹 Miscellaneous Chores

* remove sideEffects from analyze ([#1444](#1444)) ([572aaa0](572aaa0))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @arcjet/protocol bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/body: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/body-v1.0.0-alpha.23) (2024-09-02)


### 🧹 Miscellaneous Chores

* **@arcjet/body:** Synchronize arcjet-js versions


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/bun: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/bun-v1.0.0-alpha.23) (2024-09-02)


### 🧹 Miscellaneous Chores

* **@arcjet/bun:** Synchronize arcjet-js versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @arcjet/env bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/headers bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/ip bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/logger bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/protocol bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/transport bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * arcjet bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/decorate: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/decorate-v1.0.0-alpha.23) (2024-09-02)


### 🧹 Miscellaneous Chores

* **@arcjet/decorate:** Synchronize arcjet-js versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @arcjet/protocol bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/sprintf bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/duration: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/duration-v1.0.0-alpha.23) (2024-09-02)


### 🧹 Miscellaneous Chores

* **@arcjet/duration:** Synchronize arcjet-js versions


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/env: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/env-v1.0.0-alpha.23) (2024-09-02)


### 🧹 Miscellaneous Chores

* **@arcjet/env:** Synchronize arcjet-js versions


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/eslint-config: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/eslint-config-v1.0.0-alpha.23) (2024-09-02)


### 🧹 Miscellaneous Chores

* **@arcjet/eslint-config:** Synchronize arcjet-js versions
</details>

<details><summary>@arcjet/headers: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/headers-v1.0.0-alpha.23) (2024-09-02)


### 🧹 Miscellaneous Chores

* **@arcjet/headers:** Synchronize arcjet-js versions


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/ip: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/ip-v1.0.0-alpha.23) (2024-09-02)


### 🧹 Miscellaneous Chores

* **@arcjet/ip:** Synchronize arcjet-js versions


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/logger: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/logger-v1.0.0-alpha.23) (2024-09-02)


### 🧹 Miscellaneous Chores

* **@arcjet/logger:** Synchronize arcjet-js versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @arcjet/sprintf bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/next: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/next-v1.0.0-alpha.23) (2024-09-02)


### 🧹 Miscellaneous Chores

* **@arcjet/next:** Synchronize arcjet-js versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @arcjet/env bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/headers bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/ip bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/logger bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/protocol bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/transport bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * arcjet bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/node: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/node-v1.0.0-alpha.23) (2024-09-02)


### 🧹 Miscellaneous Chores

* **@arcjet/node:** Synchronize arcjet-js versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @arcjet/env bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/headers bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/ip bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/logger bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/protocol bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/transport bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/body bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * arcjet bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/protocol: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/protocol-v1.0.0-alpha.23) (2024-09-02)


### 🧹 Miscellaneous Chores

* **@arcjet/protocol:** Synchronize arcjet-js versions


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/redact: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/redact-v1.0.0-alpha.23) (2024-09-02)


### 🚀 New Features

* add library to perform redaction of sensitive information ([#1358](#1358)) ([59d4a0d](59d4a0d))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @arcjet/redact-wasm bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/redact-wasm: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/redact-wasm-v1.0.0-alpha.23) (2024-09-02)


### 🚀 New Features

* add library to perform redaction of sensitive information ([#1358](#1358)) ([59d4a0d](59d4a0d))


### 🪲 Bug Fixes

* Ensure instantiation throws if WebAssembly is unavailable ([#1458](#1458)) ([0edfd45](0edfd45))


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/rollup-config: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/rollup-config-v1.0.0-alpha.23) (2024-09-02)


### 🧹 Miscellaneous Chores

* **@arcjet/rollup-config:** Synchronize arcjet-js versions


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/runtime: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/runtime-v1.0.0-alpha.23) (2024-09-02)


### 🧹 Miscellaneous Chores

* **@arcjet/runtime:** Synchronize arcjet-js versions


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/sprintf: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/sprintf-v1.0.0-alpha.23) (2024-09-02)


### 🧹 Miscellaneous Chores

* **@arcjet/sprintf:** Synchronize arcjet-js versions


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/sveltekit: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/sveltekit-v1.0.0-alpha.23) (2024-09-02)


### 🧹 Miscellaneous Chores

* **@arcjet/sveltekit:** Synchronize arcjet-js versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @arcjet/env bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/headers bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/ip bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/logger bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/protocol bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/transport bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * arcjet bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/transport: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/transport-v1.0.0-alpha.23) (2024-09-02)


### 🧹 Miscellaneous Chores

* **transport:** Reduce idle timeout for AWS Global Accelerator ([#1479](#1479)) ([cd1df38](cd1df38))


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>@arcjet/tsconfig: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](https://github.com/arcjet/arcjet-js/compare/v1.0.0-alpha.22...@arcjet/tsconfig-v1.0.0-alpha.23) (2024-09-02)


### 🧹 Miscellaneous Chores

* **@arcjet/tsconfig:** Synchronize arcjet-js versions
</details>

<details><summary>arcjet: 1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](v1.0.0-alpha.22...arcjet-v1.0.0-alpha.23) (2024-09-02)


### 🪲 Bug Fixes

* **analyze:** Ensure headers are serialized correctly ([#1435](#1435)) ([0319412](0319412))
* **arcjet:** Infer types when no detect function is specified ([#1446](#1446)) ([8ae0370](8ae0370))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @arcjet/analyze bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/duration bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/headers bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/protocol bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/runtime bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
  * devDependencies
    * @arcjet/eslint-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/rollup-config bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
    * @arcjet/tsconfig bumped from 1.0.0-alpha.22 to 1.0.0-alpha.23
</details>

<details><summary>1.0.0-alpha.23</summary>

## [1.0.0-alpha.23](v1.0.0-alpha.22...v1.0.0-alpha.23) (2024-09-02)


### 🚀 New Features

* add library to perform redaction of sensitive information ([#1358](#1358)) ([59d4a0d](59d4a0d))


### 🪲 Bug Fixes

* **analyze:** Ensure headers are serialized correctly ([#1435](#1435)) ([0319412](0319412))
* **arcjet:** Infer types when no detect function is specified ([#1446](#1446)) ([8ae0370](8ae0370))
* Ensure instantiation throws if WebAssembly is unavailable ([#1458](#1458)) ([0edfd45](0edfd45))


### 🧹 Miscellaneous Chores

* **deps:** bump webpack and @nestjs/cli in /examples/nodejs-nestjs ([#1456](#1456)) ([8d125ac](8d125ac))
* **example:** Remove env package usage ([#1457](#1457)) ([f09f3d3](f09f3d3))
* remove sideEffects from analyze ([#1444](#1444)) ([572aaa0](572aaa0))
* **transport:** Reduce idle timeout for AWS Global Accelerator ([#1479](#1479)) ([cd1df38](cd1df38))
</details>

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate Fingerprint does not work correctly
2 participants