Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distinguish "default":true search-view from "searchViewDefault":true so one search-view doesn't need to do everything #11546

Open
whatisgalen opened this issue Oct 15, 2024 · 0 comments · May be fixed by #11547

Comments

@whatisgalen
Copy link
Member

When you set a search-view to default: true so that it gets used by default when a user goes to the Search page, that search-view is now used by default every single time the search_results url is hit. This means that if you have a search-view that doesn't use, say, the vanilla "term-filter", any query parameters nested under "term-filter" will be discarded and those searches will not work as expected (for example the resource-instance select widget in the resource-instance datatype). One way to fix this would be to incorporate new keys on the search-view config json to distinguish a search-view as a "globalDefault" vs one that is just the "searchViewDefault". That way a developer doesn't need to worry about side effects from their custom searchview when normal Arches search requests get sent.

@chiatt chiatt added this to pipeline Oct 15, 2024
whatisgalen added a commit that referenced this issue Oct 15, 2024
whatisgalen added a commit that referenced this issue Oct 15, 2024
@whatisgalen whatisgalen changed the title distinguish search-views by "globalDefault" and "searchViewDefault" so one search-view doesn't need to do everything distinguish "default":true search-view from "searchViewDefault":true so one search-view doesn't need to do everything Oct 15, 2024
@whatisgalen whatisgalen linked a pull request Oct 15, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant