Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle disconnection gracefully #14

Closed
whereswaldon opened this issue Nov 16, 2018 · 2 comments
Closed

Handle disconnection gracefully #14

whereswaldon opened this issue Nov 16, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@whereswaldon
Copy link
Member

The client should not become unusable when it is disconnected from the server. Instead, it should become readonly, or (better yet) allow you to create messages marked as pending a live server connection.
@whereswaldon whereswaldon added the enhancement New feature or request label Nov 16, 2018
@whereswaldon whereswaldon mentioned this issue Dec 6, 2018
Merged
@whereswaldon
Copy link
Member Author

As of #43, the client is completely usable in a readonly way when you disconnect. It will discover that it is disconnected whenever a networking call returns an error, which usually happens when a user attempts to send a message. Right now, this message is lost (but the client reconnects). I need to ensure that this message is no longer lost.

@whereswaldon
Copy link
Member Author

Made issue #46 to track work on the lost message. I think I will close this, since disconnection (when detected) is handled gracefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whereswaldon