Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update .env template #125

Merged
merged 3 commits into from
Oct 26, 2023
Merged

update .env template #125

merged 3 commits into from
Oct 26, 2023

Conversation

itutu-tienday
Copy link
Collaborator

@itutu-tienday itutu-tienday commented Oct 26, 2023 •
edited
Loading

  • FE dotenv の整理
    • アプリケーションのportに関連する設定を .env へ集約

@ReiHashimoto
少し別件となりますが、このPRに合わせて、以下の修正を取り込んでおいていただければと思います。

@ReiHashimoto
Copy link

@itutu-tienday
更新されたdotenvへの適応と、arayabrain#212 の反映を行いました。
こちらで意図されていた内容は合っていますか？

@itutu-tienday
Copy link
Collaborator Author

@ReiHashimoto
ありがとうございます。 修正内容OKです。

なお すみません、説明で記載の issue no に誤りがありました。

@ReiHashimoto ReiHashimoto merged commit 79b3be7 into develop-main Oct 26, 2023
4 checks passed
@ReiHashimoto ReiHashimoto deleted the feature/improve-dotenv-template branch October 26, 2023 10:34
@itutu-tienday itutu-tienday linked an issue Oct 26, 2023 that may be closed by this pull request
Improve FE dotenv and Docker port setting #126
Closed
@ReiHashimoto ReiHashimoto mentioned this pull request Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReiHashimoto ReiHashimoto ReiHashimoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve FE dotenv and Docker port setting
2 participants
@itutu-tienday @ReiHashimoto