Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Data Node Test Implemented #407 #427

Merged
merged 8 commits into from
Nov 19, 2024

Conversation

tsuchiyama-araya
Copy link
Collaborator

Adding Data Node Test Implemented #407

Contents:

  • mocked store to pass into the component. Then tested if it shows properly
  • Tested when the Data Nodes is Clicked then Image clicked it will verify that the action was dispatched with the expected payload

AddOns -> Fixed Typo for Function Name.

All Tests Run After Implementing New Test:
Screenshot 2024-09-02 at 14 20 25

@tsuchiyama-araya
Copy link
Collaborator Author

How to do the test

1.) git checkout feature/#407_add_data_node_test
2.) go to frontend directory
3.) run yarn install
4.) run yarn run test

It should run the tests. All of it should be passing.

@milesAraya
Copy link
Collaborator

Seems to work correctly
yarn install
yarn run test
Output:

(node:74770) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.
(Use node --trace-deprecation ... to show where the warning was created)
PASS src/store/slice/AlgorithmList/AlgorithmList.test.ts
PASS src/store/test/visualize/Visualize.test.ts
(node:74769) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.
(Use node --trace-deprecation ... to show where the warning was created)
(node:74772) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.
(Use node --trace-deprecation ... to show where the warning was created)
PASS src/store/test/RunSelectors.test.ts (5.536 s)
PASS src/store/test/record/RecordReproduce.test.ts (5.537 s)
PASS src/store/slice/Experiments/Experiments.test.ts
PASS src/store/test/workflow/AlgorithmNode/AlgorithmNode.test.ts
One of your dependencies, babel-preset-react-app, is importing the
"@babel/plugin-proposal-private-property-in-object" package without
declaring it in its dependencies. This is currently working because
"@babel/plugin-proposal-private-property-in-object" is already in your
node_modules folder for unrelated reasons, but it may break at any time.

babel-preset-react-app is part of the create-react-app project, which
is not maintianed anymore. It is thus unlikely that this bug will
ever be fixed. Add "@babel/plugin-proposal-private-property-in-object" to
your devDependencies to work around this error. This will make this message
go away.

PASS src/store/test/workflow/InputNode/InputNode.test.ts
One of your dependencies, babel-preset-react-app, is importing the
"@babel/plugin-proposal-private-property-in-object" package without
declaring it in its dependencies. This is currently working because
"@babel/plugin-proposal-private-property-in-object" is already in your
node_modules folder for unrelated reasons, but it may break at any time.

babel-preset-react-app is part of the create-react-app project, which
is not maintianed anymore. It is thus unlikely that this bug will
ever be fixed. Add "@babel/plugin-proposal-private-property-in-object" to
your devDependencies to work around this error. This will make this message
go away.

PASS src/store/slice/FilesTree/FilesTree.test.ts
One of your dependencies, babel-preset-react-app, is importing the
"@babel/plugin-proposal-private-property-in-object" package without
declaring it in its dependencies. This is currently working because
"@babel/plugin-proposal-private-property-in-object" is already in your
node_modules folder for unrelated reasons, but it may break at any time.

babel-preset-react-app is part of the create-react-app project, which
is not maintianed anymore. It is thus unlikely that this bug will
ever be fixed. Add "@babel/plugin-proposal-private-property-in-object" to
your devDependencies to work around this error. This will make this message
go away.

(node:74771) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.
(Use node --trace-deprecation ... to show where the warning was created)
One of your dependencies, babel-preset-react-app, is importing the
"@babel/plugin-proposal-private-property-in-object" package without
declaring it in its dependencies. This is currently working because
"@babel/plugin-proposal-private-property-in-object" is already in your
node_modules folder for unrelated reasons, but it may break at any time.

babel-preset-react-app is part of the create-react-app project, which
is not maintianed anymore. It is thus unlikely that this bug will
ever be fixed. Add "@babel/plugin-proposal-private-property-in-object" to
your devDependencies to work around this error. This will make this message
go away.

PASS src/components/Workspace/FlowChart/TreeView.test.tsx (9.943 s)

Test Suites: 9 passed, 9 total
Tests: 27 passed, 27 total
Snapshots: 0 total
Time: 11.883 s
Ran all test suites.

Copy link
Collaborator

@milesAraya milesAraya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is a good opportunity to update yarn to include
@babel/plugin-proposal-private-property-in-object
and use an alternative to punycode

@tsuchiyama-araya
Copy link
Collaborator Author

@milesAraya Thank you for checking. I will try to update yarn.

@tsuchiyama-araya
Copy link
Collaborator Author

@milesAraya
お疲れ様です。
@babel/plugin-proposal-private-property-in-object に関しては対応しましたが、punycodeについてはなかなか解決はできないため、一旦放置しています。
現状は優先するものではないかと思います。

@tsuchiyama-araya tsuchiyama-araya changed the base branch from feature/test_environment_implementation to develop-test September 10, 2024 23:56
@itutu-tienday itutu-tienday added this to the ver1.2.2 milestone Nov 19, 2024
@tsuchiyama-araya tsuchiyama-araya merged commit d0147ec into develop-test Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【FrontEnd Test】add data node by clicking "+"
3 participants