Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust interface to allow better use as a Library #33

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adjust interface to allow better use as a Library #33

wants to merge 5 commits into from

Commits on Nov 22, 2011

  1. Modifications to enable usage as a CocoaPods Library 

     * Move Strings to Appirator.bundle
 * Add German translations
 * Adjust API so APPIRATER_APP_ID is set at runtime:

    Remove APPIRATER_APP_ID and refactor the

        appLaunched:(BOOL)canPromptForRating

    method to take the appID at launch:

        appLaunchedWithAppStoreID:(int)appID canPromptForRating:(BOOL)canPromptForRating

    Also move strings to localization files.
    @mk
    mk committed Nov 22, 2011
    Configuration menu
    Copy the full SHA
    7ea98c6 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2011

  1. Use #ifs for APPIRATER_DEBUG instead of runtime check.

    @triplef @mk
    triplef authored and mk committed Nov 23, 2011
    Configuration menu
    Copy the full SHA
    a583843 View commit details
    Browse the repository at this point in the history

  2. Use GCD instead of threads. 

    Was previously creating a new thread for every call to
+userDidSignificantEvent, +appEnteredForeground, and +appLaunched.
    @triplef @mk
    triplef authored and mk committed Nov 23, 2011
    Configuration menu
    Copy the full SHA
    1c61736 View commit details
    Browse the repository at this point in the history

  3. Use GCD dispatch_once instead of @synchronized for +sharedInstance. 

    This is supposed to be faster, see e.g.
http://www.mikeash.com/pyblog/friday-qa-2009-09-18-intro-to-grand-central-dispatch-part-iv-odds-and-ends.html
    @triplef @mk
    triplef authored and mk committed Nov 23, 2011
    Configuration menu
    Copy the full SHA
    797abff View commit details
    Browse the repository at this point in the history

  4. Tweak: use UKKit constant instead of string.

    @triplef @mk
    triplef authored and mk committed Nov 23, 2011
    Configuration menu
    Copy the full SHA
    810029b View commit details
    Browse the repository at this point in the history