-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GCD instead of threads #27
base: master
Are you sure you want to change the base?
Conversation
Was previously creating a new thread for every call to +userDidSignifica ntEvent, +appEnteredForeground, and +appLaunched.
AWESOME work! #pragma mark GCD Singleton
|
Good idea! Just changed it to use dispatch_once. Thanks! |
np - I've been testing your commit the last few days and no problems - nice update! |
I like the idea of using GCD, but I need to make sure Appirater remains compatible for developers who still need to deploy on iOS3 devices (myself included :-/ ). |
@arashpayan - no problem, except Apple will be making that decision for you (meaning say around iOS 5.1 or 5.2, Apple will bump the min OS and remove 3.x from the list, for new apps). :-) Of course for Game center apps all these "rate my app" projects will no longer be needed in 5.x ( i'll be keeping it in my apps for non-game center users, which there are still a lot of) |
+1, can we please use this? It's been 6 months, iOS 3 is barely relevant any more. |
iOS 6 is now out... no one cares about the first iteration iPhone. Time to merge this into master? ;) |
Was previously creating a new thread for every call to +userDidSignificantEvent, +appEnteredForeground, and +appLaunched, which is unnecessarily expensive (especially for apps calling userDidSignificantEvent often).