Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: Csprng should take a shared reference #12

Open
elagergren-spideroak opened this issue Jan 8, 2025 · 2 comments · May be fixed by aranya-project/aranya-core#47
Open

crypto: Csprng should take a shared reference #12

elagergren-spideroak opened this issue Jan 8, 2025 · 2 comments · May be fixed by aranya-project/aranya-core#47
Assignees
@elagergren-spideroak

Comments

@elagergren-spideroak
Copy link
Member

elagergren-spideroak commented Jan 8, 2025 •
edited
Loading

No description provided.

@elagergren-spideroak elagergren-spideroak self-assigned this Jan 8, 2025
elagergren-spideroak referenced this issue in aranya-project/aranya-core Jan 8, 2025
@elagergren-spideroak
crypto: Csprng should take a shared ref
7dfc312 
Fixes #46

Signed-off-by: Eric Lagergren <[email protected]>
@elagergren-spideroak elagergren-spideroak linked a pull request Jan 8, 2025 that will close this issue
Draft
@elagergren-spideroak elagergren-spideroak linked a pull request Jan 8, 2025 that will close this issue
crypto: Csprng should take a shared ref aranya-project/aranya-core#47
Draft
@elagergren-spideroak
Copy link
Member Author

@jdygert-spok as an aside, thoughts about using fn foo<R: Csprng>(rng: &R) vs fn foo<R: Csprng>(rng: R) vs fn foo(rng: impl Csprng)?

@jdygert-spok
Copy link

"by value" is preferred in std at least. I'd do impl Csprng here since shouldn't be any need to explicitly specify the type or connect it to anything else.

@elagergren-spideroak elagergren-spideroak transferred this issue from aranya-project/aranya-core Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elagergren-spideroak elagergren-spideroak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

crypto: Csprng should take a shared ref aranya-project/aranya-core
2 participants
@elagergren-spideroak @jdygert-spok