Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRD arangomember is deployed by both charts: kube-arangodb and kube-arangodb-crd #740

Closed
BernhardBerbuir opened this issue Jun 18, 2021 · 5 comments

Comments

@BernhardBerbuir
Copy link

The CRD arangomember is deployed by both charts: kube-arangodb and kube-arangodb-crd
=> the last chart wins

I would suggest that only the chart kube-arangodb-crd create CRDs.

@ajanikow
Copy link
Collaborator

Hello!

We want to include CRD creation into kube-arangodb chart into crds section. It is recommended by Helm3 right now.

It was first step for migration, we will move other charts under kube-arangodb.

If order of installation is like described in docs - first kube-arangodb-crd, then kube-arangodb- everything should go fine.kube-arangodb-crdshould install new CRD, after thatkube-arangodb` should be fine that CRD exists. If this statement is wrong we will update flow, but it passed all manual tests.

Best Regards,
Adam.

@BernhardBerbuir
Copy link
Author

In my opinion it would be better to separate K8S Cluster admin task and K8S namespace admin tasks as they are different concerns:

  • cluster admin: creates CRDs, ClusterRoles and ClusterColebinding
  • Namespace admin: creates ServiceAccount and ArangoDB operator

Otherwise only a K8S Cluster admin can use the chart

@ajanikow
Copy link
Collaborator

Hello!

We can achieve isolation with this approach - CRD from helm are installed as optional. Currently, it is split like this:

  • In kube-arangodb we support namespaced mode, so it can be installed within namespace (without admin access). You can skip CRD installation by helm command flag (--skip-crds).
  • CRD can be installed before by system-admin - even using kubectl, helm command - directly from kube-arangodb chart.

Best Regards,
Adam.

@sarahhenkens
Copy link

Thoughts on adding a helm values to wrap the CRD that can be disabled from the values.yaml? With some CD systems like ArgoCD, we can't pass in command line arguments to helm

@ajanikow
Copy link
Collaborator

Hello!

CRD chart is not required anymore.

Best,
Adam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants