Create more reliable collection shards test

Author: informalict

CHANGELOG.md

@@ -1,6 +1,7 @@
 # Change Log
 
 ## [master](https://github.com/arangodb/go-driver/tree/master) (N/A)
+- Add support for fetching shards' info by the given collection name.
 
 ## [1.2.0](https://github.com/arangodb/go-driver/tree/1.2.0) (2021-08-04)
 - Add support for AQL, Pipeline, Stopwords, GeoJSON and GeoPoint Arango Search analyzers.

test/collection_test.go

@@ -972,7 +972,7 @@ func Test_CollectionShards(t *testing.T) {
 		t.Skipf("Not a cluster mode")
 	}
 
-	databaseName := getThisFunctionName()
+	databaseName := getCallerFunctionName()
 	c := createClientFromEnv(t, true)
 	db := ensureDatabase(nil, c, databaseName, nil, t)
 	name := "test_collection_set_properties"
@@ -984,11 +984,27 @@ func Test_CollectionShards(t *testing.T) {
 
 	shards, err := col.Shards(context.Background(), true)
 	require.NoError(t, err)
+	assert.NotEmpty(t, shards.ID)
+	assert.Equal(t, name, shards.Name)
+	assert.NotEmpty(t, shards.Status)
+	assert.Equal(t, driver.CollectionTypeDocument, shards.Type)
+	assert.Equal(t, false, shards.IsSystem)
+	assert.NotEmpty(t, shards.GloballyUniqueId)
+	assert.Equal(t, false, shards.CacheEnabled)
+	assert.Equal(t, false, shards.IsSmart)
+	assert.Equal(t, driver.KeyGeneratorTraditional, shards.KeyOptions.Type)
+	assert.Equal(t, true, shards.KeyOptions.AllowUserKeys)
+	assert.Equal(t, 2, shards.NumberOfShards)
+	assert.Equal(t, driver.ShardingStrategyHash, shards.ShardingStrategy)
+	assert.Equal(t, []string{"_key"}, shards.ShardKeys)
 	require.Len(t, shards.Shards, 2, "expected 2 shards")
 	var leaders []driver.ServerID
 	for _, dbServers := range shards.Shards {
 		require.Lenf(t, dbServers, 2, "expected 2 DB servers for the shard")
 		leaders = append(leaders, dbServers[0])
 	}
 	assert.NotEqualf(t, leaders[0], leaders[1], "the leader shard can not be on the same server")
+	assert.Equal(t, 2, shards.ReplicationFactor)
+	assert.Equal(t, false, shards.WaitForSync)
+	assert.Equal(t, 1, shards.WriteConcern)
 }

test/util.go

@@ -215,8 +215,8 @@ func min(max int, ints ...int) int {
 	return z
 }
 
-// getThisFunctionName returns the name of the function of the caller.
-func getThisFunctionName() string {
+// getCallerFunctionName returns the name of the function of the caller.
+func getCallerFunctionName() string {
 	programCounters := make([]uintptr, 10)
 	// skip this function and 'runtime.Callers' function
 	runtime.Callers(2, programCounters)

v2/tests/database_collection_operations_test.go

@@ -52,14 +52,29 @@ func Test_CollectionShards(t *testing.T) {
 				shards, err := col.Shards(context.Background(), true)
 				require.NoError(t, err)
 
+				assert.NotEmpty(t, shards.ID)
+				assert.Equal(t, col.Name(), shards.Name)
+				assert.NotEmpty(t, shards.Status)
+				assert.Equal(t, arangodb.CollectionTypeDocument, shards.Type)
+				assert.Equal(t, false, shards.IsSystem)
+				assert.NotEmpty(t, shards.GloballyUniqueId)
+				assert.Equal(t, false, shards.CacheEnabled)
+				assert.Equal(t, false, shards.IsSmart)
+				assert.Equal(t, arangodb.KeyGeneratorTraditional, shards.KeyOptions.Type)
+				assert.Equal(t, true, shards.KeyOptions.AllowUserKeys)
+				assert.Equal(t, 2, shards.NumberOfShards)
+				assert.Equal(t, arangodb.ShardingStrategyHash, shards.ShardingStrategy)
+				assert.Equal(t, []string{"_key"}, shards.ShardKeys)
 				require.Len(t, shards.Shards, 2, "expected 2 shards")
 				var leaders []arangodb.ServerID
-
 				for _, dbServers := range shards.Shards {
 					require.Lenf(t, dbServers, 2, "expected 2 DB servers for the shard")
 					leaders = append(leaders, dbServers[0])
 				}
 				assert.NotEqualf(t, leaders[0], leaders[1], "the leader shard can not be on the same server")
+				assert.Equal(t, 2, shards.ReplicationFactor)
+				assert.Equal(t, false, shards.WaitForSync)
+				assert.Equal(t, 1, shards.WriteConcern)
 			})
 		})
 	})